Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose CEL execution prometheus metrics #195

Open
a-hilaly opened this issue Jan 9, 2025 · 2 comments
Open

expose CEL execution prometheus metrics #195

a-hilaly opened this issue Jan 9, 2025 · 2 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/feature

Comments

@a-hilaly
Copy link
Member

a-hilaly commented Jan 9, 2025

Feature Description

Currently kro lacks observability around CEL expression execution. we need to add prometheus metrics similar to the Kubernetes API server to track CEL evaluation performance and failures. These metrics will help operators monitor the health and performance of ResourceGroups/I reconcilers.

We should follow the pattern from:
https://github.com/kubernetes/apiserver/blob/2241ea00526fdd746871375dfca871627f6a511a/pkg/cel/metrics/metrics.go#L32-L62

@a-hilaly a-hilaly added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 29, 2025
@harshithsaiv
Copy link

Hi @a-hilaly !

I would love to contribute to this. Can I give this a try? If possible, could you assign it to me?

Thanks!

@a-hilaly
Copy link
Member Author

a-hilaly commented Feb 5, 2025

@a-hilaly Absolutely, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/feature
Projects
None yet
Development

No branches or pull requests

2 participants