Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created CRDs do not have a Ready or Succeeded condition. #268

Open
n3wscott opened this issue Feb 3, 2025 · 1 comment
Open

Created CRDs do not have a Ready or Succeeded condition. #268

n3wscott opened this issue Feb 3, 2025 · 1 comment
Labels
kind/bug Something isn't working

Comments

@n3wscott
Copy link
Contributor

n3wscott commented Feb 3, 2025

Description

Observed Behavior:
There is no top level ready condition in the generated CRD.

Expected Behavior:
Each CRD uses a Ready or Succeeded condition type as its top level condition.

See also: The wrong way to Reconcile

Which option describes the most your issue?

No response
@n3wscott n3wscott added the kind/bug Something isn't working label Feb 3, 2025
@barney-s
Copy link
Member

barney-s commented Feb 5, 2025

We need more than just top level ready condition. We also need to deal with changes in schema and version in the generated CRD. Lets collect our thoughts here with examples and draft a new set of requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@barney-s @n3wscott