Skip to content

Commit 02224cc

Browse files
Tooling maintenance (JetBrains#3606)
* Update Gradle to 8.3 in tooling * Introduce version catalogs * Update Kotlin * Update Intellij SDK plugin * Update download plugin * Update shadow jar plugin * Update Gradle plugin portal plugin
1 parent 96dad84 commit 02224cc

File tree

10 files changed

+53
-26
lines changed

10 files changed

+53
-26
lines changed

gradle-plugins/build.gradle.kts

+6-4
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,11 @@ import com.gradle.publish.PluginBundleExtension
22
import org.jetbrains.kotlin.gradle.tasks.KotlinJvmCompile
33

44
plugins {
5-
val kotlinVersion = "1.7.20"
6-
kotlin("jvm") version kotlinVersion apply false
7-
kotlin("plugin.serialization") version kotlinVersion apply false
8-
id("com.gradle.plugin-publish") version "0.17.0" apply false
5+
alias(libs.plugins.kotlin.jvm) apply false
6+
alias(libs.plugins.kotlin.serialization) apply false
7+
alias(libs.plugins.publish.plugin.portal) apply false
8+
alias(libs.plugins.shadow.jar) apply false
9+
alias(libs.plugins.download) apply false
910
}
1011

1112
subprojects {
@@ -33,6 +34,7 @@ subprojects {
3334
// which is bundled to the oldest supported Gradle
3435
kotlinOptions.languageVersion = "1.5"
3536
kotlinOptions.apiVersion = "1.5"
37+
kotlinOptions.jvmTarget = "1.8"
3638
}
3739
}
3840

gradle-plugins/buildSrc/src/main/kotlin/BuildProperties.kt

-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ object BuildProperties {
1111
const val group = "org.jetbrains.compose"
1212
const val website = "https://www.jetbrains.com/lp/compose/"
1313
const val vcs = "https://github.com/JetBrains/compose-jb"
14-
const val serializationVersion = "1.2.1"
1514
fun composeVersion(project: Project): String =
1615
System.getenv("COMPOSE_GRADLE_PLUGIN_COMPOSE_VERSION")
1716
?: project.findProperty("compose.version") as String

gradle-plugins/compose/build.gradle.kts

+14-14
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@ import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar
22
import de.undercouch.gradle.tasks.download.Download
33

44
plugins {
5-
kotlin("jvm")
6-
kotlin("plugin.serialization")
7-
id("com.gradle.plugin-publish")
5+
alias(libs.plugins.kotlin.jvm)
6+
alias(libs.plugins.kotlin.serialization)
7+
alias(libs.plugins.publish.plugin.portal)
88
id("java-gradle-plugin")
99
id("maven-publish")
10-
id("com.github.johnrengelman.shadow") version "7.0.0"
11-
id("de.undercouch.download") version "5.3.0"
10+
alias(libs.plugins.shadow.jar)
11+
alias(libs.plugins.download)
1212
}
1313

1414
gradlePluginConfig {
@@ -35,7 +35,7 @@ tasks.named("compileKotlin") {
3535
dependsOn(buildConfig)
3636
}
3737
sourceSets.main.configure {
38-
java.srcDir(buildConfigDir)
38+
java.srcDir(buildConfig.flatMap { it.generatedOutputDir })
3939
}
4040

4141
val embeddedDependencies by configurations.creating {
@@ -63,12 +63,10 @@ dependencies {
6363
testImplementation(gradleTestKit())
6464
testImplementation(kotlin("gradle-plugin-api"))
6565

66-
// include relocated download task to avoid potential runtime conflicts
67-
embedded("de.undercouch:gradle-download-task:5.3.0")
68-
69-
embedded("org.jetbrains.kotlinx:kotlinx-serialization-json:${BuildProperties.serializationVersion}")
70-
embedded("org.jetbrains.kotlinx:kotlinx-serialization-core:${BuildProperties.serializationVersion}")
71-
embedded("org.jetbrains.kotlinx:kotlinx-serialization-core-jvm:${BuildProperties.serializationVersion}")
66+
embedded(libs.download.task)
67+
embedded(libs.serialization.json)
68+
embedded(libs.serialization.core)
69+
embedded(libs.serialization.core.jvm)
7270
embedded(project(":preview-rpc"))
7371
embedded(project(":jdk-version-probe"))
7472
}
@@ -77,7 +75,9 @@ val shadow = tasks.named<ShadowJar>("shadowJar") {
7775
val fromPackage = "de.undercouch"
7876
val toPackage = "org.jetbrains.compose.$fromPackage"
7977
relocate(fromPackage, toPackage)
80-
archiveClassifier.set("shadow")
78+
archiveBaseName.set("shadow")
79+
archiveClassifier.set("")
80+
archiveVersion.set("")
8181
configurations = listOf(embeddedDependencies)
8282
exclude("META-INF/gradle-plugins/de.undercouch.download.properties")
8383
exclude("META-INF/versions/**")
@@ -165,7 +165,7 @@ for (gradleVersion in supportedGradleVersions) {
165165
configureAllTests {
166166
dependsOn(":publishToMavenLocal")
167167
systemProperty("compose.tests.compose.gradle.plugin.version", BuildProperties.deployVersion(project))
168-
val summaryDir = project.buildDir.resolve("test-summary")
168+
val summaryDir = project.layout.buildDirectory.get().asFile.resolve("test-summary")
169169
systemProperty("compose.tests.summary.file", summaryDir.resolve("$name.md").absolutePath)
170170
systemProperties(project.properties.filter { it.key.startsWith("compose.") })
171171
}

gradle-plugins/gradle.properties

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ compose.tests.compiler.compatible.kotlin.version=1.9.0
1010
# The latest version of Kotlin compatible with compose.tests.compiler.version for JS target. Used only on CI.
1111
compose.tests.js.compiler.compatible.kotlin.version=1.9.0
1212
# __SUPPORTED_GRADLE_VERSIONS__
13-
compose.tests.gradle.versions=7.3.3, 8.1
13+
compose.tests.gradle.versions=7.3.3, 8.3
1414

1515
# A version of Gradle plugin, that will be published,
1616
# unless overridden by COMPOSE_GRADLE_PLUGIN_VERSION env var.
+17
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
[versions]
2+
kotlin = "1.9.0"
3+
gradle-download-plugin = "5.5.0"
4+
kotlinx-serialization = "1.2.1"
5+
6+
[libraries]
7+
download-task = { module = "de.undercouch:gradle-download-task", version.ref = "gradle-download-plugin" }
8+
serialization-json = { module = "org.jetbrains.kotlinx:kotlinx-serialization-json", version.ref = "kotlinx-serialization" }
9+
serialization-core = { module = "org.jetbrains.kotlinx:kotlinx-serialization-core", version.ref = "kotlinx-serialization" }
10+
serialization-core-jvm = { module = "org.jetbrains.kotlinx:kotlinx-serialization-core-jvm", version.ref = "kotlinx-serialization" }
11+
12+
[plugins]
13+
kotlin-jvm = { id = "org.jetbrains.kotlin.jvm", version.ref = "kotlin" }
14+
kotlin-serialization = { id = "org.jetbrains.kotlin.plugin.serialization", version.ref = "kotlin" }
15+
shadow-jar = "com.github.johnrengelman.shadow:8.1.1"
16+
download = { id = "de.undercouch.download", version.ref = "gradle-download-plugin" }
17+
publish-plugin-portal = "com.gradle.plugin-publish:1.2.1"
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6-bin.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-8.3-bin.zip
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists

gradle-plugins/preview-rpc/build.gradle.kts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
plugins {
2-
kotlin("jvm")
2+
alias(libs.plugins.kotlin.jvm)
33
id("maven-publish")
44
}
55

idea-plugin/build.gradle.kts

+3-3
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ import org.jetbrains.kotlin.gradle.tasks.KotlinJvmCompile
22

33
plugins {
44
id("java")
5-
id("org.jetbrains.kotlin.jvm") version "1.5.10"
6-
id("org.jetbrains.intellij") version "1.12.0"
7-
id("org.jetbrains.changelog") version "1.3.1"
5+
alias(libs.plugins.kotlin.jvm)
6+
alias(libs.plugins.intellij.sdk)
7+
alias(libs.plugins.intellij.changelog)
88
}
99

1010
val projectProperties = ProjectProperties(project)

idea-plugin/gradle/libs.versions.toml

+9
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
[versions]
2+
kotlin = "1.9.0"
3+
4+
[libraries]
5+
6+
[plugins]
7+
kotlin-jvm = { id = "org.jetbrains.kotlin.jvm", version.ref = "kotlin" }
8+
intellij-sdk = "org.jetbrains.intellij:1.15.0"
9+
intellij-changelog = "org.jetbrains.changelog:2.2.0"
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6-bin.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-8.3-bin.zip
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists

0 commit comments

Comments
 (0)