Skip to content

Commit f58d6ad

Browse files
committed
Remove double cmake files
1 parent f52b3af commit f58d6ad

6 files changed

+34
-51
lines changed

CMakeLists.txt

+22-27
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ project(kColorPicker LANGUAGES CXX VERSION 0.3.0)
33

44
set(QT_MIN_VERSION "5.9.4")
55

6-
set(CMAKE_CXX_STANDARD 11)
6+
set(CMAKE_CXX_STANDARD 17)
77
set(CMAKE_CXX_STANDARD_REQUIRED ON)
88
set(CMAKE_CXX_EXTENSIONS OFF)
99

@@ -15,12 +15,9 @@ option(BUILD_EXAMPLE "Build Example Application" ON)
1515

1616
option(BUILD_WITH_QT6 "Build with Qt6" OFF)
1717
if(BUILD_WITH_QT6)
18-
set(CMAKE_CXX_STANDARD 17)
1918
set(QT_MAJOR_VERSION 6)
20-
set(kColorPicker_LIB_NAME "kColorPicker-Qt6")
2119
else()
2220
set(QT_MAJOR_VERSION 5)
23-
set(kColorPicker_LIB_NAME "kColorPicker-Qt5")
2421
endif()
2522

2623
find_package(Qt${QT_MAJOR_VERSION} ${QT_MIN_VERSION} REQUIRED Widgets)
@@ -44,26 +41,24 @@ endif (BUILD_TESTS)
4441

4542
include(CMakePackageConfigHelpers)
4643

47-
add_library(${kColorPicker_LIB_NAME}
44+
add_library(kColorPicker
4845
${KCOLORPICKER_SRCS}
4946
${CMAKE_CURRENT_SOURCE_DIR}/include/kColorPicker/KColorPicker.h
5047
${CMAKE_CURRENT_SOURCE_DIR}/icons/kColorPicker_icons.qrc
5148
)
5249

53-
#add_library(kColorPicker::kColorPicker ALIAS kColorPicker)
54-
55-
target_include_directories(${kColorPicker_LIB_NAME}
50+
target_include_directories(kColorPicker
5651
PUBLIC
5752
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
5853
$<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/include>
59-
$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>/${kColorPicker_LIB_NAME}
54+
$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}/kColorPicker-Qt${QT_MAJOR_VERSION}>
6055
)
6156

62-
target_link_libraries(${kColorPicker_LIB_NAME} PUBLIC Qt${QT_MAJOR_VERSION}::Widgets)
57+
target_link_libraries(kColorPicker PUBLIC Qt${QT_MAJOR_VERSION}::Widgets)
6358

64-
target_compile_definitions(${kColorPicker_LIB_NAME} PRIVATE KIMAGEANNOTATOR_LIB)
59+
target_compile_definitions(kColorPicker PRIVATE KIMAGEANNOTATOR_LIB)
6560

66-
set_target_properties(${kColorPicker_LIB_NAME}
61+
set_target_properties(kColorPicker
6762
PROPERTIES
6863
ARCHIVE_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/lib
6964
LIBRARY_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/lib
@@ -72,43 +67,43 @@ set_target_properties(${kColorPicker_LIB_NAME}
7267
SOVERSION 0
7368
)
7469

75-
install(TARGETS ${kColorPicker_LIB_NAME}
76-
EXPORT ${kColorPicker_LIB_NAME}-targets
70+
install(TARGETS kColorPicker
71+
EXPORT kColorPicker-targets
7772
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
7873
LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
7974
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
8075
)
8176

8277
install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/include/kColorPicker
83-
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/${kColorPicker_LIB_NAME}
78+
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/kColorPicker-Qt${QT_MAJOR_VERSION}
8479
)
8580

86-
configure_package_config_file(${CMAKE_CURRENT_SOURCE_DIR}/cmake/${kColorPicker_LIB_NAME}Config.cmake.in
87-
${CMAKE_CURRENT_BINARY_DIR}/cmake/${kColorPicker_LIB_NAME}Config.cmake
88-
INSTALL_DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/${kColorPicker_LIB_NAME}
81+
configure_package_config_file(${CMAKE_CURRENT_SOURCE_DIR}/cmake/kColorPickerConfig.cmake.in
82+
${CMAKE_CURRENT_BINARY_DIR}/cmake/kColorPicker-Qt${QT_MAJOR_VERSION}Config.cmake
83+
INSTALL_DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/kColorPicker-Qt${QT_MAJOR_VERSION}
8984
)
9085

91-
write_basic_package_version_file(${CMAKE_CURRENT_BINARY_DIR}/cmake/${kColorPicker_LIB_NAME}Config-version.cmake
86+
write_basic_package_version_file(${CMAKE_CURRENT_BINARY_DIR}/cmake/kColorPicker-Qt${QT_MAJOR_VERSION}Config-version.cmake
9287
VERSION ${PROJECT_VERSION}
9388
COMPATIBILITY AnyNewerVersion
9489
)
9590

9691
install(FILES
97-
${CMAKE_CURRENT_BINARY_DIR}/cmake/${kColorPicker_LIB_NAME}Config.cmake
98-
${CMAKE_CURRENT_BINARY_DIR}/cmake/${kColorPicker_LIB_NAME}Config-version.cmake
99-
DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/${kColorPicker_LIB_NAME}
92+
${CMAKE_CURRENT_BINARY_DIR}/cmake/kColorPicker-Qt${QT_MAJOR_VERSION}Config.cmake
93+
${CMAKE_CURRENT_BINARY_DIR}/cmake/kColorPicker-Qt${QT_MAJOR_VERSION}Config-version.cmake
94+
DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/kColorPicker-Qt${QT_MAJOR_VERSION}
10095
)
10196

10297

103-
export(EXPORT ${kColorPicker_LIB_NAME}-targets
104-
FILE ${CMAKE_CURRENT_BINARY_DIR}/cmake/${kColorPicker_LIB_NAME}-targets.cmake
98+
export(EXPORT kColorPicker-targets
99+
FILE ${CMAKE_CURRENT_BINARY_DIR}/cmake/kColorPicker-Qt${QT_MAJOR_VERSION}-targets.cmake
105100
NAMESPACE kColorPicker::
106101
)
107102

108-
install(EXPORT ${kColorPicker_LIB_NAME}-targets
109-
FILE ${kColorPicker_LIB_NAME}-targets.cmake
103+
install(EXPORT kColorPicker-targets
104+
FILE kColorPicker-targets.cmake
110105
NAMESPACE kColorPicker::
111-
DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/${kColorPicker_LIB_NAME}
106+
DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/kColorPicker-Qt${QT_MAJOR_VERSION}
112107
)
113108

114109
# uninstall target

README.md

+2-5
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,8 @@ only build as static library.
3636
to build with Qt6:
3737
`find_package(kColorPicker-Qt6 ${KCOLORPICKER_MIN_VERSION} REQUIRED)`
3838

39-
2. Link the library with your application
40-
if you built with Qt5:
41-
`target_link_libraries(myApp kColorPicker-Qt5)`
42-
if you built with Qt6:
43-
`target_link_libraries(myApp kColorPicker-Qt6)`
39+
2. Link the library with your application
40+
`target_link_libraries(myApp kColorPicker)`
4441

4542

4643
[github-badge]: https://github.com/ksnip/kColorPicker/actions/workflows/build.yml/badge.svg

cmake/kColorPicker-Qt5Config.cmake.in

-9
This file was deleted.

cmake/kColorPicker-Qt6Config.cmake.in

-9
This file was deleted.

cmake/kColorPickerConfig.cmake.in

+9
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
include(CMakeFindDependencyMacro)
2+
3+
@PACKAGE_INIT@
4+
5+
find_dependency(Qt@QT_MAJOR_VERSION@ @QT_MIN_VERSION@ COMPONENTS Widgets)
6+
7+
if(NOT TARGET kColorPicker::kColorPicker)
8+
include("${CMAKE_CURRENT_LIST_DIR}/kColorPicker-targets.cmake")
9+
endif()

example/CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
add_executable(kColorPicker-example main.cpp)
22

3-
target_link_libraries(kColorPicker-example ${kColorPicker_LIB_NAME})
3+
target_link_libraries(kColorPicker-example kColorPicker)

0 commit comments

Comments
 (0)