Skip to content

Commit e589482

Browse files
SuperPaintmanjosteink
authored andcommitted
Add support for strict TypeScript mode
1 parent d48a432 commit e589482

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

src/gmail.d.ts

+8-8
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ interface GmailGet {
215215
/**
216216
Does the same as visible_emails, but with a callback instead.
217217
*/
218-
visible_emails_async(callback: (emails: string[]) => void);
218+
visible_emails_async(callback: (emails: string[]) => void): void;
219219
/**
220220
Returns a list of object representation from emails that are
221221
currently selected in the inbox view. The data does not come
@@ -255,7 +255,7 @@ interface GmailGet {
255255
string or binary format depending on the value of the
256256
`preferBinary`-parameter.
257257
*/
258-
email_source_async(email_id: string, callback: (email_source: string | Uint8Array) => void, error_callback?: (jqxhr, textStatus: string, errorThrown: string) => void, preferBinary?: boolean): void;
258+
email_source_async(email_id: string, callback: (email_source: string | Uint8Array) => void, error_callback?: (jqxhr: JQueryXHR, textStatus: string, errorThrown: string) => void, preferBinary?: boolean): void;
259259
/**
260260
Does the same as email_source_async, but uses ES6 promises.
261261
*/
@@ -616,10 +616,10 @@ interface GmailTools {
616616
observes every element inserted into the DOM by Gmail and looks at the classes on those elements,
617617
checking for any configured observers related to those classes
618618
*/
619-
insertion_observer(target: HTMLElement | string, dom_observers: any, dom_observer_map: any, sub: any);
619+
insertion_observer(target: HTMLElement | string, dom_observers: any, dom_observer_map: any, sub: any): void;
620620

621621
make_request(link: string, method: GmailHttpRequestMethod, disable_cache: boolean): string;
622-
make_request_async(link: string, method: GmailHttpRequestMethod, callback: (data: string) => void, disable_cache: boolean);
622+
make_request_async(link: string, method: GmailHttpRequestMethod, callback: (data: string) => void, disable_cache: boolean): void;
623623

624624
/**
625625
Creates a request to download user-content from Gmail.
@@ -672,7 +672,7 @@ interface GmailTools {
672672
673673
return-value is jQuery-instance representing the created button.
674674
*/
675-
add_attachment_button(attachment: GmailDomAttachment, contentHtml: string | null, customCssClas: string | null, tooltip: string, onClickFunction: Function);
675+
add_attachment_button(attachment: GmailDomAttachment, contentHtml: string | null, customCssClas: string | null, tooltip: string, onClickFunction: Function): JQuery;
676676

677677
remove_modal_window(): void;
678678
add_modal_window(title: string, content_html: string, onClickOk: Function, onClickCancel?: Function, onClickClose?: Function): void;
@@ -729,13 +729,13 @@ interface GmailObserve {
729729
on(action: "view_thread", callback: (obj: GmailDomThread) => void): void;
730730
on(action: "view_email", callback: (obj: GmailDomEmail) => void): void;
731731
on(action: "load_email_menu", callback: (obj: JQuery) => void): void;
732-
on(action: "compose", callback: (GmailDomCompose, type: GmailComposeType) => void): void;
732+
on(action: "compose", callback: (obj: GmailDomCompose, type: GmailComposeType) => void): void;
733733
on(action: "load", callback: () => void): void;
734734
/**
735735
This is the key feature of gmail.js. This method allows you to
736736
add triggers to all of these actions so you can build your
737737
custom extension/tool with this library.
738-
738+
739739
You simply specify the action name and your function that the
740740
method will return data to when the actions are triggered and
741741
it does the rest. You can have multiple triggers
@@ -775,7 +775,7 @@ interface GmailObserve {
775775
/**
776776
Trigger any specified DOM events passing a specified element & optional handler
777777
*/
778-
trigger_dom(observer: any, element: HTMLElement, handler?: Function);
778+
trigger_dom(observer: any, element: HTMLElement, handler?: Function): void;
779779

780780
initialize_dom_observers(): void;
781781

tsconfig.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
"compilerOptions": {
3-
"target": "es6"
3+
"target": "es6",
4+
"strict": true
45
}
56
}

0 commit comments

Comments
 (0)