Skip to content

Commit 3e2ac7c

Browse files
authored
Merge pull request #7 from ksysoev/perfomance_improvments
Improve stability of server test
2 parents 8f44657 + 020b025 commit 3e2ac7c

File tree

2 files changed

+3
-12
lines changed

2 files changed

+3
-12
lines changed

server.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ type Server struct {
2727
handlers map[string]RequestHandler
2828
handlersLock *sync.RWMutex
2929
cancel context.CancelFunc
30-
sem chan struct{}
30+
sem chan token
3131
wg *sync.WaitGroup
3232
stream string
3333
group string
@@ -54,7 +54,7 @@ func NewServer(redisClient *redis.Client, stream, group, consumer string, opts .
5454
ctx: ctx,
5555
cancel: cancel,
5656
consumer: consumer,
57-
sem: make(chan struct{}, DefaultConcurency),
57+
sem: make(chan token, DefaultConcurency),
5858
wg: &sync.WaitGroup{},
5959
}
6060

server_test.go

+1-10
Original file line numberDiff line numberDiff line change
@@ -244,20 +244,11 @@ func TestServer_Close(t *testing.T) {
244244
group := "myGroup"
245245
consumer := "myConsumer"
246246

247-
xReadArgs := &redis.XReadGroupArgs{
248-
Group: group,
249-
Consumer: consumer,
250-
Streams: []string{stream, ">"},
251-
Block: DefaultBlockInterval,
252-
Count: DefaultConcurency,
253-
NoAck: false,
254-
}
255-
256247
mock.ExpectXGroupCreateMkStream(stream, group, "$").SetVal("OK")
257248
mock.ExpectXGroupCreateConsumer(stream, group, consumer).SetVal(1)
258-
mock.ExpectXReadGroup(xReadArgs).SetErr(redis.Nil)
259249

260250
server := NewServer(redisClient, stream, group, consumer)
251+
server.sem = make(chan token)
261252

262253
done := make(chan struct{})
263254
go func() {

0 commit comments

Comments
 (0)