When property of type object contains empty additionalProperties nonexistant type is generated

[Dennor]

When an type object contains empty additional properties such this kopium generates non existant type and compilation fails with

help: you might be missing a type parameter
      |
22921 | pub struct TidbClusterStatusTikvFailureStores<TidbClusterStatusTikvFailureStoresPvcUidSet> {
      |                                              +++++++++++++++++++++++++++++++++++++++++++++

error[E0412]: cannot find type `TidbClusterStatusTikvFailureStoresPvcUidSet` in this scope
     --> tests/./gen.rs:22929:46
      |
22929 |     pub pvc_uid_set: Option<BTreeMap<String, TidbClusterStatusTikvFailureStoresPvcUidSet>>,
      |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not found in this scope

[clux]

Thanks for the report. I'll leave this open to people wanting to experiment for now. Here are some quick thoughts on how to go about solving it:

AFAIKT the go type is this. so i expect it to be a MapType<Uid, X> where maptype is the type of map asked for by kopium cli, and X could be another String -> String map (i think, at least it tracks with what they put down in their tests - i think this should just work without the x-kubernetes unknown-field thing annotation because they don't need this to be a serde_json::Value for single nesting like this).

A test should be similar to this test (for options field)

kopium/src/analyzer.rs

Lines 798 to 803 in 9f63975

	let schema_str = r#"
	properties:
	options:
	additionalProperties:
	type: boolean
	type: object

. if it had unknown-fields annot it should just work and be similar to this other test.

Not sure if we need to be more lenient in one of the extract container branches invoked via the recurser via analyze_, but it would be the thing to figure out after getting some tests down. It is possible they need more annotations upstream also, most crds work well at this point.

[Dennor]

I might have some time to take a stab at this myself at some point. That being the case I can't exactly commit a timeline so if someone will want to pick it up consider this message void. As in, the will is there, I'm just unsure if and when I'll have the time.

If that's fine that is.

[ClemaX]

I think that the construct is meant to describe a set. If you look at the referenced tests, you can see that the pvcUIDSet mapped value is always set to an empty struct {} and returned as-is.

There are two approaches i can think of to handle inexistent properties and additionalProperties when x-kubernetes-preserve-unknown-fields is not true:

• Use the Unit () type as value type and replace the struct reference
• Create an empty struct in extract_containers (not very useful, IMO)
• Add a set_type to Configuration and use it instead of a Map in this special case

Edit:

According to the OpenAPIv3 specification, it seems like this construct should be handled as a free form object, so maybe MapType<String, serde_json::Value> would be the correct typing.