Merge pull request #1825 from imp/imp/clippy

assorted clippy cleanups

Author: clux

examples/shared_stream_controllers.rs

@@ -1,6 +1,6 @@
-use std::{ops::Deref, sync::Arc, time::Duration};
+use std::{future, ops::Deref, sync::Arc, time::Duration};
 
-use futures::{future, StreamExt};
+use futures::StreamExt;
 use k8s_openapi::api::{apps::v1::Deployment, core::v1::Pod};
 use kube::{
     runtime::{

kube-client/src/client/builder.rs

@@ -298,7 +298,7 @@ mod tests {
                 let io: TokioIo<TcpStream> = TokioIo::new(tcp);
 
                 tokio::spawn(async move {
-                    let _ = http1::Builder::new()
+                    http1::Builder::new()
                         .timer(TokioTimer::new())
                         .serve_connection(
                             io,

kube-client/src/client/client_ext.rs

@@ -487,12 +487,7 @@ mod test {
 
         // Fetch using local object reference
         let svc: Service = client
-            .fetch(
-                &LocalObjectReference {
-                    name: svc.name_any().into(),
-                }
-                .within(svc.namespace()),
-            )
+            .fetch(&LocalObjectReference { name: svc.name_any() }.within(svc.namespace()))
             .await?;
         assert_eq!(svc.name_unchecked(), "kubernetes");
 

kube-core/src/error_boundary.rs

@@ -62,19 +62,19 @@ impl<K: Resource> Resource for DeserializeGuard<K> {
     type DynamicType = K::DynamicType;
     type Scope = K::Scope;
 
-    fn kind(dt: &Self::DynamicType) -> Cow<str> {
+    fn kind(dt: &'_ Self::DynamicType) -> Cow<'_, str> {
         K::kind(dt)
     }
 
-    fn group(dt: &Self::DynamicType) -> Cow<str> {
+    fn group(dt: &'_ Self::DynamicType) -> Cow<'_, str> {
         K::group(dt)
     }
 
-    fn version(dt: &Self::DynamicType) -> Cow<str> {
+    fn version(dt: &'_ Self::DynamicType) -> Cow<'_, str> {
         K::version(dt)
     }
 
-    fn plural(dt: &Self::DynamicType) -> Cow<str> {
+    fn plural(dt: &'_ Self::DynamicType) -> Cow<'_, str> {
         K::plural(dt)
     }
 

kube-runtime/src/scheduler.rs

@@ -222,7 +222,10 @@ where
     ///
     /// NOTE: `can_take_message` should be considered to be fairly performance-sensitive, since
     /// it will generally be executed for each pending message, for each [`poll_next`](Self::poll_next).
-    pub fn hold_unless<C: Fn(&T) -> bool>(self: Pin<&mut Self>, can_take_message: C) -> HoldUnless<T, R, C> {
+    pub fn hold_unless<C: Fn(&T) -> bool>(
+        self: Pin<&'_ mut Self>,
+        can_take_message: C,
+    ) -> HoldUnless<'_, T, R, C> {
         HoldUnless {
             scheduler: self,
             can_take_message,
@@ -233,7 +236,7 @@ where
     /// Its equivalent to doing `self.hold_unless(|_| false)` and is useful when the
     /// consumer is not ready to consume the expired messages that the [`Scheduler`] emits.
     #[must_use]
-    pub fn hold(self: Pin<&mut Self>) -> Hold<T, R> {
+    pub fn hold(self: Pin<&'_ mut Self>) -> Hold<'_, T, R> {
         Hold { scheduler: self }
     }