KubeArmor Panic if uninitialised docker socket exists

[daemon1024]

Bug Report

KubeArmor Panic if uninitialised docker socket exists

General Information

KubeArmor/KubeArmor/core/dockerHandler.go

Lines 265 to 271 in 88f54a6

	Docker, err = NewDockerHandler()
	if err != nil {
	dm.Logger.Errf("Failed to create new Docker client: %s", err)
	}
	}
	if containerList, err := Docker.DockerClient.ContainerList(context.Background(), container.ListOptions{}); err == nil {

We don't do a return if there's an error while initialising. This creates a panic because we call the client function with a nil client. We should return early from the function.

• Environment description (ubuntu 18.04)
• Orchestration system version in use (unorchestrated)

To Reproduce

Have the docker socket file exist, but the docker daemon would be down
KubeArmor Panics on init

Expected behavior

No panic

Panic Trace

Jan 21 02:40:15 ip-172-31-28-212 kubearmor[6963]: 2025-01-21 02:40:15.673868        INFO        Verifying Docker API client version: 1.44
Jan 21 02:40:15 ip-172-31-28-212 kubearmor[6963]: 2025-01-21 02:40:15.673994        ERROR        Failed to create new Docker client: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
Jan 21 02:40:15 ip-172-31-28-212 kubearmor[6963]: github.com/kubearmor/KubeArmor/KubeArmor/log.Err
Jan 21 02:40:15 ip-172-31-28-212 kubearmor[6963]:         /home/runner/work/KubeArmor/KubeArmor/KubeArmor/log/logger.go:103
Jan 21 02:40:15 ip-172-31-28-212 kubearmor[6963]: github.com/kubearmor/KubeArmor/KubeArmor/feeder.(*Feeder).Errf
Jan 21 02:40:15 ip-172-31-28-212 kubearmor[6963]:         /home/runner/work/KubeArmor/KubeArmor/KubeArmor/feeder/feeder.go:446
Jan 21 02:40:15 ip-172-31-28-212 kubearmor[6963]: github.com/kubearmor/KubeArmor/KubeArmor/core.(*KubeArmorDaemon).GetAlreadyDeployedDockerContainers
Jan 21 02:40:15 ip-172-31-28-212 kubearmor[6963]:         /home/runner/work/KubeArmor/KubeArmor/KubeArmor/core/dockerHandler.go:265
Jan 21 02:40:15 ip-172-31-28-212 kubearmor[6963]: github.com/kubearmor/KubeArmor/KubeArmor/core.KubeArmor
Jan 21 02:40:15 ip-172-31-28-212 kubearmor[6963]:         /home/runner/work/KubeArmor/KubeArmor/KubeArmor/core/kubeArmor.go:585
Jan 21 02:40:15 ip-172-31-28-212 kubearmor[6963]: main.main
Jan 21 02:40:15 ip-172-31-28-212 kubearmor[6963]:         /home/runner/work/KubeArmor/KubeArmor/KubeArmor/main.go:79
Jan 21 02:40:15 ip-172-31-28-212 kubearmor[6963]: runtime.main
Jan 21 02:40:15 ip-172-31-28-212 kubearmor[6963]:         /home/runner/go/pkg/mod/golang.org/[email protected]/src/runtime/proc.go:267
Jan 21 02:40:15 ip-172-31-28-212 kubearmor[6963]: panic: runtime error: invalid memory address or nil pointer dereference
Jan 21 02:40:15 ip-172-31-28-212 kubearmor[6963]: [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x19e0035]
Jan 21 02:40:15 ip-172-31-28-212 kubearmor[6963]: goroutine 1 [running]:
Jan 21 02:40:15 ip-172-31-28-212 kubearmor[6963]: github.com/kubearmor/KubeArmor/KubeArmor/core.(*KubeArmorDaemon).GetAlreadyDeployedDockerContainers(0xc00015b800)
Jan 21 02:40:15 ip-172-31-28-212 kubearmor[6963]:         /home/runner/work/KubeArmor/KubeArmor/KubeArmor/core/dockerHandler.go:269 +0xb5
Jan 21 02:40:15 ip-172-31-28-212 kubearmor[6963]: github.com/kubearmor/KubeArmor/KubeArmor/core.KubeArmor()
Jan 21 02:40:15 ip-172-31-28-212 kubearmor[6963]:         /home/runner/work/KubeArmor/KubeArmor/KubeArmor/core/kubeArmor.go:585 +0x1365
Jan 21 02:40:15 ip-172-31-28-212 kubearmor[6963]: main.main()
Jan 21 02:40:15 ip-172-31-28-212 kubearmor[6963]:         /home/runner/work/KubeArmor/KubeArmor/KubeArmor/main.go:79 +0x3ed
Jan 21 02:40:17 ip-172-31-28-212 systemd[1]: kubearmor.service: Main process exited, code=exited, status=2/INVALIDARGUMENT
Jan 21 02:40:17 ip-172-31-28-212 systemd[1]: kubearmor.service: Failed with result 'exit-code'.
Jan 21 02:40:27 ip-172-31-28-212 systemd[1]: kubearmor.service: Service hold-off time over, scheduling restart.
Jan 21 02:40:27 ip-172-31-28-212 systemd[1]: kubearmor.service: Scheduled restart job, restart counter is at 6.
Jan 21 02:40:27 ip-172-31-28-212 systemd[1]: Stopped KubeArmor.
Jan 21 02:40:27 ip-172-31-28-212 systemd[1]: Started KubeArmor.

[Manik2708]

Would like to work on it!

[Manik2708]

@daemon1024 Will it be fine to return error from GetAlreadyDeployedDockerContainers? As I could see 4 usages of it and after every usage of it, monitoring of docker events is started. So we can terminate kubearmor if a situation like this appears!