complete request review for hanadb

Signed-off-by: ZobayerAbedin <[email protected]>

Author: ZobayerAbedin

catalog/copy-images.sh

@@ -471,6 +471,7 @@ $CMD cp --allow-nondistributable-artifacts --insecure prom/mysqld-exporter:v0.13
 $CMD cp --allow-nondistributable-artifacts --insecure prometheuscommunity/elasticsearch-exporter:v1.7.0 $IMAGE_REGISTRY/prometheuscommunity/elasticsearch-exporter:v1.7.0
 $CMD cp --allow-nondistributable-artifacts --insecure prometheuscommunity/postgres-exporter:v0.15.0 $IMAGE_REGISTRY/prometheuscommunity/postgres-exporter:v0.15.0
 $CMD cp --allow-nondistributable-artifacts --insecure registry.k8s.io/git-sync/git-sync:v4.4.2 $IMAGE_REGISTRY/git-sync/git-sync:v4.4.2
+$CMD cp --allow-nondistributable-artifacts --insecure saplabs/hanaexpress:2.00.082.00.20250528.1 $IMAGE_REGISTRY/saplabs/hanaexpress:2.00.082.00.20250528.1
 $CMD cp --allow-nondistributable-artifacts --insecure singlestore/cluster-in-a-box:alma-8.1.32-e3d3cde6da-4.0.16-1.17.6 $IMAGE_REGISTRY/singlestore/cluster-in-a-box:alma-8.1.32-e3d3cde6da-4.0.16-1.17.6
 $CMD cp --allow-nondistributable-artifacts --insecure singlestore/cluster-in-a-box:alma-8.5.22-fe61f40cd1-4.1.0-1.17.11 $IMAGE_REGISTRY/singlestore/cluster-in-a-box:alma-8.5.22-fe61f40cd1-4.1.0-1.17.11
 $CMD cp --allow-nondistributable-artifacts --insecure singlestore/cluster-in-a-box:alma-8.5.7-bf633c1a54-4.0.17-1.17.8 $IMAGE_REGISTRY/singlestore/cluster-in-a-box:alma-8.5.7-bf633c1a54-4.0.17-1.17.8

catalog/export-images.sh

@@ -468,6 +468,7 @@ $CMD pull --allow-nondistributable-artifacts --insecure prom/mysqld-exporter:v0.
 $CMD pull --allow-nondistributable-artifacts --insecure prometheuscommunity/elasticsearch-exporter:v1.7.0 images/prometheuscommunity-elasticsearch-exporter-v1.7.0.tar
 $CMD pull --allow-nondistributable-artifacts --insecure prometheuscommunity/postgres-exporter:v0.15.0 images/prometheuscommunity-postgres-exporter-v0.15.0.tar
 $CMD pull --allow-nondistributable-artifacts --insecure registry.k8s.io/git-sync/git-sync:v4.4.2 images/git-sync-git-sync-v4.4.2.tar
+$CMD pull --allow-nondistributable-artifacts --insecure saplabs/hanaexpress:2.00.082.00.20250528.1 images/saplabs-hanaexpress-2.00.082.00.20250528.1.tar
 $CMD pull --allow-nondistributable-artifacts --insecure singlestore/cluster-in-a-box:alma-8.1.32-e3d3cde6da-4.0.16-1.17.6 images/singlestore-cluster-in-a-box-alma-8.1.32-e3d3cde6da-4.0.16-1.17.6.tar
 $CMD pull --allow-nondistributable-artifacts --insecure singlestore/cluster-in-a-box:alma-8.5.22-fe61f40cd1-4.1.0-1.17.11 images/singlestore-cluster-in-a-box-alma-8.5.22-fe61f40cd1-4.1.0-1.17.11.tar
 $CMD pull --allow-nondistributable-artifacts --insecure singlestore/cluster-in-a-box:alma-8.5.7-bf633c1a54-4.0.17-1.17.8 images/singlestore-cluster-in-a-box-alma-8.5.7-bf633c1a54-4.0.17-1.17.8.tar

catalog/imagelist.yaml

@@ -434,11 +434,11 @@
 - prometheuscommunity/elasticsearch-exporter:v1.7.0
 - prometheuscommunity/postgres-exporter:v0.15.0
 - registry.k8s.io/git-sync/git-sync:v4.4.2
+- saplabs/hanaexpress:2.00.082.00.20250528.1
 - singlestore/cluster-in-a-box:alma-8.1.32-e3d3cde6da-4.0.16-1.17.6
 - singlestore/cluster-in-a-box:alma-8.5.22-fe61f40cd1-4.1.0-1.17.11
 - singlestore/cluster-in-a-box:alma-8.5.7-bf633c1a54-4.0.17-1.17.8
 - singlestore/cluster-in-a-box:alma-8.7.10-95e2357384-4.1.0-1.17.14
-- saplabs/hanaexpress:2.00.082.00.20250528.1
 - tianon/toybox:0.8.11
 - timescale/timescaledb:2.14.2-pg13-oss
 - timescale/timescaledb:2.14.2-pg14-oss

catalog/scripts/hanadb/import-images.sh

@@ -25,8 +25,5 @@ TARBALL=${1:-}
 tar -zxvf $TARBALL
 
 CMD="./crane"
-if [ ! -x "${CMD}" ] && [ -x "./images/crane" ]; then
-    CMD="./images/crane"
-fi
 
 $CMD push --allow-nondistributable-artifacts --insecure images/saplabs-hanaexpress-2.00.082.00.20250528.1.tar $IMAGE_REGISTRY/saplabs/hanaexpress:2.00.082.00.20250528.1

catalog/scripts/hanadb/import-into-k3s.sh

@@ -16,6 +16,11 @@
 
 set -x
 
+if [ -z "${IMAGE_REGISTRY}" ]; then
+    echo "IMAGE_REGISTRY is not set"
+    exit 1
+fi
+
 TARBALL=${1:-}
 tar -zxvf $TARBALL