Skip to content

Inconsistent top_k parameter handling in execute_tool() #19

@haroon0x

Description

@haroon0x

Priority: Low
Effort: 5 minutes

Description

In the execute_tool() function, the top_k value from arguments is retrieved but then ignored - the function always passes 15 to milvus_search():

top_k = arguments.get("top_k", 5)
# ...
result = milvus_search(query, 15)  # <-- ignores top_k!

Affected Files

  • server/app.py (line 157)
  • server-https/app.py (line 170)

Fix

Use the actual top_k value:

result = milvus_search(query, top_k)

DCO Checklist

  • I have read the Kubeflow Contributing Guide
  • I have signed off my commits using git commit -s
  • My PR title follows the convention: fix(server): use top_k parameter in milvus_search

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions