From efcafb8a10acc4f92a7fd9f4a66e9ceb4d720e98 Mon Sep 17 00:00:00 2001 From: tariq-hasan Date: Sun, 7 Apr 2024 16:10:16 -0400 Subject: [PATCH] Refactored unit test that uses cmp.Diff Signed-off-by: tariq-hasan --- .../suggestionclient/suggestionclient_test.go | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/pkg/controller.v1beta1/suggestion/suggestionclient/suggestionclient_test.go b/pkg/controller.v1beta1/suggestion/suggestionclient/suggestionclient_test.go index d11a204bf3b..79582fb9815 100644 --- a/pkg/controller.v1beta1/suggestion/suggestionclient/suggestionclient_test.go +++ b/pkg/controller.v1beta1/suggestion/suggestionclient/suggestionclient_test.go @@ -577,10 +577,12 @@ func TestConvertTrialObservation(t *testing.T) { }, } for _, tc := range tcs { - actualObservation := convertTrialObservation(tc.strategies, tc.inObservation) - if diff := cmp.Diff(actualObservation, tc.expectedObservation); diff != "" { - t.Errorf("Case: %v failed. Diff (-want,+got):\n%s", tc.testDescription, diff) - } + t.Run(tc.testDescription, func(t *testing.T) { + actualObservation := convertTrialObservation(tc.strategies, tc.inObservation) + if diff := cmp.Diff(actualObservation, tc.expectedObservation); diff != "" { + t.Errorf("Unexpected observation (-want,+got):\n%s", diff) + } + }) } }