Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Changelog for Katib v0.18.0-rc.0 #2515

Merged

Conversation

andreyvelich
Copy link
Member

Part of: #2386

I added changelog for Katib v0.18.0-rc.0. Please take a look.
I grouped PRs by:

## Breaking Changes
### Hyperparameter Optimization for LLMs
### Control Plane Updates
### SDK Updates
## Bug Fixes
## Misc

Thanks everyone for your contributions 🎉

/assign @kubeflow/wg-training-leads @Electronic-Waste @helenxie-bit @kubeflow/release-team @shashank-iitbhu @saileshd1402 @mahdikhashan @forsaken628 @Jerry-yz @AydanPirani @mahdikhashan @Doris-xm @lianghao208 @caiofralmeida @gonmmarques @Ygnas @droctothorpe @jaffe-fly @eltociear @tariq-hasan @ckcd @vihangm

/hold for review

Signed-off-by: Andrey Velichkevich <[email protected]>
Copy link
Member

@Electronic-Waste Electronic-Waste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM! Thanks for this! @andreyvelich

CHANGELOG.md Outdated
- [GSoC] Update `tune` API for LLM hyperparameters optimization ([#2393](https://github.com/kubeflow/katib/pull/2393) by [@helenxie-bit](https://github.com/helenxie-bit))
- [GSoC] Create LLM Hyperparameters Optimization API Proposal ([#2333](https://github.com/kubeflow/katib/pull/2333) by [@helenxie-bit](https://github.com/helenxie-bit))

### Control Plane Updates
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we split this section into two separate sections like: Multiple Parameter Distribution and Push-based Metrics Collection? Since they are main features in 0.18.0, it would be more clear if we replace it with these two sections.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense.

CHANGELOG.md Outdated
- [SDK] Support PyTorchJob as a Trial Worker ([#2512](https://github.com/kubeflow/katib/pull/2512) by [@andreyvelich](https://github.com/andreyvelich))
- [SDK] test: Add e2e test for tune function. ([#2399](https://github.com/kubeflow/katib/pull/2399) by [@Electronic-Waste](https://github.com/Electronic-Waste))
- [SDK] improve PVC creation name error ([#2496](https://github.com/kubeflow/katib/pull/2496) by [@mahdikhashan](https://github.com/mahdikhashan))
- [GSoC] Add New Parameter in `tune` ([#2369](https://github.com/kubeflow/katib/pull/2369) by [@Electronic-Waste](https://github.com/Electronic-Waste))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can move it to Push-based Metrics Collection section if the comment above is adopted.

Signed-off-by: Andrey Velichkevich <[email protected]>
Copy link
Member

@Electronic-Waste Electronic-Waste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Let's merge our work to 0.18.0!

/lgtm

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, otherwise lgtm

Co-authored-by: Yuki Iwai <[email protected]>
Signed-off-by: Andrey Velichkevich <[email protected]>
@google-oss-prow google-oss-prow bot removed the lgtm label Feb 13, 2025
@tenzen-y
Copy link
Member

Thx
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Electronic-Waste, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich
Copy link
Member Author

/hold cancel

@google-oss-prow google-oss-prow bot merged commit 338a5c1 into kubeflow:master Feb 13, 2025
66 checks passed
@andreyvelich andreyvelich deleted the add-changelog-v0.18.0-rc.0 branch February 13, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants