Upgrade kubernetes Go module version to 1.32 #2450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuki Iwai <[email protected]>
tenzen-y
force-pushed
the
upgrade-kube-1.32
branch
from
eb9e83d to
8ea9ba1
Compare
|
Based on #2448 (comment), we decided to upgrade the module version immediately. /assign @andreyvelich |
tenzen-y
commented
Feb 25, 2025
| @@ -1,35 +1,35 @@ | |||
| module github.com/kubeflow/trainer | |||
|
|
|||
| go 1.23 | |||
| go 1.23.0 | |||
There was a problem hiding this comment.
This patch version prevents tools version insertion.
1 task
|
Thank you @tenzen-y! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, astefanutti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I upgraded kube related go module version to 1.32.
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Part-of #2434
Checklist: