Skip to content

Commit 1701dba

Browse files
xmudriikubermatic-bot
authored andcommitted
E2E: Don't error in wait.Poll (#244)
1 parent 4b01b1b commit 1701dba

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

test/e2e/upgrade_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ func waitForNodesReady(nodeClient corev1types.NodeInterface) error {
172172
for _, n := range nodes.Items {
173173
for _, c := range n.Status.Conditions {
174174
if c.Type == corev1.NodeReady && c.Status != corev1.ConditionTrue {
175-
return false, errors.Errorf("node %s is not running", n.ObjectMeta.Name)
175+
return false, nil
176176
}
177177
}
178178
}
@@ -200,7 +200,7 @@ func waitForNodesUpgraded(nodeClient corev1types.NodeInterface, targetVersion st
200200
return false, err
201201
}
202202
if reqVer.Compare(kubeletVer) != 0 {
203-
return false, errors.Errorf("kubelet version mismatch: expected %v, got %v", reqVer.String(), kubeletVer.String())
203+
return false, nil
204204
}
205205
}
206206
return true, nil

0 commit comments

Comments
 (0)