Pass CancellationToken from StreamConnectAsync to webSocketBuilder.BuildAndConnectAsync (#1504)

nathanwoctopusdeploy · web-flow · commit 465c1fdca296 · 2024-01-22T09:12:20.000+01:00
diff --git a/src/KubernetesClient/Kubernetes.WebSocket.cs b/src/KubernetesClient/Kubernetes.WebSocket.cs
@@ -281,8 +281,7 @@ protected async Task<WebSocket> StreamConnectAsync(Uri uri, string webSocketSubP
             try
             {
                 BeforeRequest();
-                webSocket = await webSocketBuilder.BuildAndConnectAsync(uri, CancellationToken.None)
-                    .ConfigureAwait(false);
+                webSocket = await webSocketBuilder.BuildAndConnectAsync(uri, cancellationToken).ConfigureAwait(false);
             }
             catch (WebSocketException wse) when (wse.WebSocketErrorCode == WebSocketError.HeaderError ||
                                                  (wse.InnerException is WebSocketException &&

Original file line number	Diff line number	Diff line change
`@@ -281,8 +281,7 @@ protected async Task<WebSocket> StreamConnectAsync(Uri uri, string webSocketSubP`
`281`	`281`	`try`
`282`	`282`	`{`
`283`	`283`	`BeforeRequest();`
`284`		`- webSocket = await webSocketBuilder.BuildAndConnectAsync(uri, CancellationToken.None)`
`285`		`- .ConfigureAwait(false);`
	`284`	`+ webSocket = await webSocketBuilder.BuildAndConnectAsync(uri, cancellationToken).ConfigureAwait(false);`
`286`	`285`	`}`
`287`	`286`	`catch (WebSocketException wse) when (wse.WebSocketErrorCode == WebSocketError.HeaderError \|\|`
`288`	`287`	`(wse.InnerException is WebSocketException &&`