Skip to content

Commit af3bfcd

Browse files
authored
Merge pull request #499 from testwill/ioutil
chore: remove refs to deprecated io/ioutil
2 parents a38752d + 699725f commit af3bfcd

File tree

10 files changed

+20
-24
lines changed

10 files changed

+20
-24
lines changed

cmd/server/app/server.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ import (
2121
"crypto/tls"
2222
"crypto/x509"
2323
"fmt"
24-
"io/ioutil"
2524
"net"
2625
"net/http"
2726
netpprof "net/http/pprof"
@@ -274,7 +273,7 @@ func (p *Proxy) getTLSConfig(caFile, certFile, keyFile, cipherSuites string) (*t
274273
}
275274

276275
certPool := x509.NewCertPool()
277-
caCert, err := ioutil.ReadFile(filepath.Clean(caFile))
276+
caCert, err := os.ReadFile(filepath.Clean(caFile))
278277
if err != nil {
279278
return nil, fmt.Errorf("failed to read cluster CA cert %s: %v", caFile, err)
280279
}

cmd/test-client/main.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import (
2323
"flag"
2424
"fmt"
2525
"golang.org/x/net/http2"
26-
"io/ioutil"
26+
"io"
2727
"net"
2828
"net/http"
2929
"os"
@@ -385,7 +385,7 @@ func (c *Client) makeRequest(o *GrpcProxyClientOptions, client *http.Client) err
385385
}
386386
}() // TODO: proxy server should handle the case where Body isn't closed.
387387

388-
data, err := ioutil.ReadAll(response.Body)
388+
data, err := io.ReadAll(response.Body)
389389
if err != nil {
390390
return fmt.Errorf("failed to read response from client, got %v", err)
391391
}

pkg/agent/client.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import (
2020
"context"
2121
"fmt"
2222
"io"
23-
"io/ioutil"
23+
"os"
2424
"net"
2525
runpprof "runtime/pprof"
2626
"strconv"
@@ -286,7 +286,7 @@ func (a *Client) initializeAuthContext(ctx context.Context) (context.Context, er
286286
var b []byte
287287

288288
// load current service account's token value
289-
if b, err = ioutil.ReadFile(a.serviceAccountTokenPath); err != nil {
289+
if b, err = os.ReadFile(a.serviceAccountTokenPath); err != nil {
290290
klog.ErrorS(err, "Failed to read token", "path", a.serviceAccountTokenPath)
291291
return nil, err
292292
}

pkg/util/certificates.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,14 @@ import (
2020
"crypto/tls"
2121
"crypto/x509"
2222
"fmt"
23-
"io/ioutil"
23+
"os"
2424
"path/filepath"
2525
)
2626

2727
// getCACertPool loads CA certificates to pool
2828
func getCACertPool(caFile string) (*x509.CertPool, error) {
2929
certPool := x509.NewCertPool()
30-
caCert, err := ioutil.ReadFile(filepath.Clean(caFile))
30+
caCert, err := os.ReadFile(filepath.Clean(caFile))
3131
if err != nil {
3232
return nil, fmt.Errorf("failed to read CA cert %s: %v", caFile, err)
3333
}

tests/agent_disconnect_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import (
2020
"bufio"
2121
"context"
2222
"fmt"
23-
"io/ioutil"
23+
"io"
2424
"net"
2525
"net/http"
2626
"net/http/httptest"
@@ -175,7 +175,7 @@ func clientRequest(c *http.Client, addr string) ([]byte, error) {
175175
return nil, fmt.Errorf("http GET %q: %w", addr, err)
176176
}
177177

178-
data, err := ioutil.ReadAll(r.Body)
178+
data, err := io.ReadAll(r.Body)
179179
if err != nil {
180180
return nil, fmt.Errorf("error reading response body: %w", err)
181181
}

tests/concurrent_client_request_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import (
2020
"bytes"
2121
"context"
2222
"fmt"
23-
"io/ioutil"
23+
"io"
2424
"net/http"
2525
"net/http/httptest"
2626
"sync"
@@ -41,7 +41,7 @@ type simpleServer struct {
4141
// ServeHTTP blocks the response to the request whose body is "1" until a
4242
// request whose body is "2" is handled.
4343
func (s *simpleServer) ServeHTTP(w http.ResponseWriter, req *http.Request) {
44-
bytes, err := ioutil.ReadAll(req.Body)
44+
bytes, err := io.ReadAll(req.Body)
4545
if err != nil {
4646
w.Write([]byte(err.Error()))
4747
}
@@ -161,7 +161,7 @@ func TestConcurrentClientRequest(t *testing.T) {
161161
t.Error(err)
162162
return
163163
}
164-
data, err := ioutil.ReadAll(r.Body)
164+
data, err := io.ReadAll(r.Body)
165165
if err != nil {
166166
t.Error(err)
167167
}
@@ -178,7 +178,7 @@ func TestConcurrentClientRequest(t *testing.T) {
178178
t.Error(err)
179179
return
180180
}
181-
data, err := ioutil.ReadAll(r.Body)
181+
data, err := io.ReadAll(r.Body)
182182
if err != nil {
183183
t.Error(err)
184184
}

tests/concurrent_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ package tests
1818

1919
import (
2020
"context"
21-
"io/ioutil"
21+
"io"
2222
"net/http"
2323
"net/http/httptest"
2424
"sync"
@@ -70,7 +70,7 @@ func TestProxy_ConcurrencyGRPC(t *testing.T) {
7070
return
7171
}
7272

73-
data, err := ioutil.ReadAll(r.Body)
73+
data, err := io.ReadAll(r.Body)
7474
if err != nil {
7575
t.Error(err)
7676
return

tests/custom_alpn_test.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ import (
2020
"context"
2121
"crypto/tls"
2222
"encoding/pem"
23-
"io/ioutil"
2423
"net/http"
2524
"net/http/httptest"
2625
"os"
@@ -47,7 +46,7 @@ func TestCustomALPN(t *testing.T) {
4746
}
4847
svr.StartTLS()
4948

50-
ca, err := ioutil.TempFile("", "")
49+
ca, err := os.CreateTemp("", "")
5150
if err != nil {
5251
t.Fatal(err)
5352
}

tests/ha_proxy_server_test.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ package tests
1919
import (
2020
"context"
2121
"io"
22-
"io/ioutil"
2322
"log"
2423
"math/rand"
2524
"net"
@@ -211,7 +210,7 @@ func testProxyServer(t *testing.T, front string, target string) {
211210
t.Fatal(err)
212211
}
213212

214-
data, err := ioutil.ReadAll(r.Body)
213+
data, err := io.ReadAll(r.Body)
215214
if err != nil {
216215
t.Error(err)
217216
}

tests/proxy_test.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ import (
2121
"context"
2222
"fmt"
2323
"io"
24-
"io/ioutil"
2524
"math/rand"
2625
"net"
2726
"net/http"
@@ -162,7 +161,7 @@ func TestBasicProxy_GRPC(t *testing.T) {
162161
}
163162
defer r.Body.Close()
164163

165-
data, err := ioutil.ReadAll(r.Body)
164+
data, err := io.ReadAll(r.Body)
166165
if err != nil {
167166
t.Error(err)
168167
}
@@ -600,7 +599,7 @@ func TestProxy_LargeResponse(t *testing.T) {
600599
t.Error(err)
601600
}
602601

603-
data, err := ioutil.ReadAll(r.Body)
602+
data, err := io.ReadAll(r.Body)
604603
if err != nil {
605604
t.Error(err)
606605
}
@@ -669,7 +668,7 @@ func TestBasicProxy_HTTPCONN(t *testing.T) {
669668
t.Error(err)
670669
}
671670

672-
data, err := ioutil.ReadAll(r.Body)
671+
data, err := io.ReadAll(r.Body)
673672
if err != nil {
674673
t.Error(err)
675674
}

0 commit comments

Comments
 (0)