Fix linter and tests

Signed-off-by: Danil-Grigorev <[email protected]>

Author: Danil-Grigorev

internal/controller/manifests_downloader.go

@@ -144,10 +144,10 @@ func (p *PhaseReconciler) checkConfigMapExists(ctx context.Context, labelSelecto
 func (p *PhaseReconciler) Finalize(ctx context.Context) (*Result, error) {
 	err := setCacheHash(ctx, p.ctrlClient, p.provider)
 	if err != nil {
-		ctrl.LoggerFrom(ctx).V(5).Error(err, "Failed to update providers ConfigMap hash")
+		ctrl.LoggerFrom(ctx).V(5).Error(err, "Failed to update providers hash")
 	}
 
-	return &Result{}, wrapPhaseError(err, "failed to update providers ConfigMap hash", operatorv1.ProviderInstalledCondition)
+	return &Result{}, wrapPhaseError(err, "failed to update providers hash", operatorv1.ProviderInstalledCondition)
 }
 
 // prepareConfigMapLabels returns labels that identify a config map with downloaded manifests.

internal/controller/phases.go

@@ -659,7 +659,7 @@ func addNamespaceIfMissing(objs []unstructured.Unstructured, targetNamespace str
 	return objs
 }
 
-// upgrade ensure all the clusterctl CRDs are available before installing the provider,
+// Upgrade ensure all the clusterctl CRDs are available before installing the provider,
 // and update existing components if required.
 func (p *PhaseReconciler) Upgrade(ctx context.Context) (*Result, error) {
 	log := ctrl.LoggerFrom(ctx)
@@ -832,7 +832,7 @@ func (p *PhaseReconciler) repositoryProxy(ctx context.Context, provider configcl
 		return nil, err
 	}
 
-	return repositoryProxy{Client: cl, components: nil}, nil
+	return repositoryProxy{Client: cl, components: p.components}, nil
 }
 
 // newClusterClient returns a clusterctl client for interacting with management cluster.