chore(unit): Replace magic numbers with existing constants

Signed-off-by: Borja Clemente <borja.clemente@gmail.com>

Author: clebs

controllers/awscluster_controller_test.go

@@ -1485,10 +1485,10 @@ func mockedCallsForMissingEverything(m *mocks.MockEC2APIMockRecorder, e *mocks.M
 		LoadBalancerName: aws.String("test-cluster-apiserver"),
 		HealthCheck: &elbtypes.HealthCheck{
 			Target:             aws.String("TCP:6443"),
-			Interval:           aws.Int32(5),
-			Timeout:            aws.Int32(4),
-			HealthyThreshold:   aws.Int32(2),
-			UnhealthyThreshold: aws.Int32(6),
+			Interval:           aws.Int32(infrav1.DefaultAPIServerHealthCheckIntervalSec),
+			Timeout:            aws.Int32(infrav1.DefaultAPIServerHealthCheckTimeoutSec),
+			HealthyThreshold:   aws.Int32(infrav1.DefaultAPIServerHealthThresholdCount),
+			UnhealthyThreshold: aws.Int32(infrav1.DefaultAPIServerUnhealthThresholdCount),
 		},
 	})).Return(&elb.ConfigureHealthCheckOutput{}, nil)
 }

pkg/cloud/services/elb/loadbalancer_test.go

@@ -56,10 +56,10 @@ var stubInfraV1TargetGroupSpecAPI = infrav1.TargetGroupSpec{
 	Port:     infrav1.DefaultAPIServerPort,
 	Protocol: "TCP",
 	HealthCheck: &infrav1.TargetGroupHealthCheck{
-		IntervalSeconds:         aws.Int64(5),
-		TimeoutSeconds:          aws.Int64(4),
-		ThresholdCount:          aws.Int64(2),
-		UnhealthyThresholdCount: aws.Int64(6),
+		IntervalSeconds:         aws.Int64(infrav1.DefaultAPIServerHealthCheckIntervalSec),
+		TimeoutSeconds:          aws.Int64(infrav1.DefaultAPIServerHealthCheckTimeoutSec),
+		ThresholdCount:          aws.Int64(infrav1.DefaultAPIServerHealthThresholdCount),
+		UnhealthyThresholdCount: aws.Int64(infrav1.DefaultAPIServerUnhealthThresholdCount),
 	},
 }