Skip to content

Commit 820ee87

Browse files
edmondceausuroot
authored and
root
committed
updated documentation and code to reflect kubebuilder behavior
1 parent f15726f commit 820ee87

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

docs/book/src/topics/eks/addons.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ overwrite
3030
preserve
3131
```
3232

33-
_Note_: For `conflictResolution` `none` is the **default** behaviour. That means, if not otherwise specified, it's
34-
set to `none`. Review [API Documentation](https://docs.aws.amazon.com/eks/latest/APIReference/API_CreateAddon.html#AmazonEKS-CreateAddon-request-resolveConflicts) for detailed behavior.
33+
_Note_: For `conflictResolution` `overwrite` is the **default** behaviour. That means, if not otherwise specified, it's
34+
set to `overwrite`. Review [API Documentation](https://docs.aws.amazon.com/eks/latest/APIReference/API_CreateAddon.html#AmazonEKS-CreateAddon-request-resolveConflicts) for detailed behavior.
3535

3636
Additionally, there is a cluster [flavor](https://cluster-api.sigs.k8s.io/clusterctl/commands/generate-cluster.html#flavors)
3737
called [eks-managedmachinepool-vpccni](https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/main/templates/cluster-template-eks-managedmachinepool-vpccni.yaml) that you can use with **clusterctl**:

pkg/cloud/services/eks/addons.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,8 @@ func convertConflictResolution(conflict ekscontrolplanev1.AddonResolution) (*str
224224
case ekscontrolplanev1.AddonResolutionPreserve:
225225
return aws.String(eks.ResolveConflictsPreserve), nil
226226

227+
// Defaulting to behavior "Overwrite" as documented
227228
default:
228-
return aws.String(eks.ResolveConflictsNone), fmt.Errorf("failed to determine adddonResolution; defaulting to None")
229+
return aws.String(eks.ResolveConflictsOverwrite), fmt.Errorf("failed to determine adddonResolution; defaulting to Overwrite")
229230
}
230231
}

0 commit comments

Comments
 (0)