Skip to content

Switch to windows-2022 images by default and in e2e #5357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mboersma opened this issue Jan 7, 2025 · 3 comments · May be fixed by #5635
Open

Switch to windows-2022 images by default and in e2e #5357

mboersma opened this issue Jan 7, 2025 · 3 comments · May be fixed by #5635
Assignees
@mboersma
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v1.20

Comments

@mboersma
Copy link
Contributor

mboersma commented Jan 7, 2025

/kind cleanup

What needs cleanup:

Currently e2e tests and the default VM image code in CAPZ are still returning windows-2019 images, but these are deprecated and we've stopped publishing them.

We need to change a few variables to -2022 from -2019 and clean up any unit tests that break. But since we've had problems with this in the past (see #5192 and #4867), it's probably not going to just work and investigation will be needed.

Describe the solution you'd like

Anything else you would like to add:
@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 7, 2025
@mboersma mboersma changed the title Switch to windows-2022 containers by default and in e2e Switch to windows-2022 images by default and in e2e Jan 7, 2025
@mboersma mboersma mentioned this issue Jan 10, 2025
Merged
4 tasks
@nawazkh nawazkh added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jan 23, 2025
@jsturtevant
Copy link
Contributor

The Windows Server 2022 images patch images from May-November were broken for several networking issues: microsoft/Windows-Containers#516

We've updated our upstream testing so use the CAPZ community sub and the latest images (Patches from December2024+) and we have passing tests: https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/ci-kubernetes-e2e-capz-master-containerd-nightly-windows/1883938461862334464

This may have been part of the issue that you were encountering

@desek
Copy link

desek commented Mar 14, 2025

I noticed there hasn't been any new Windows Server 2022 images published since 130.3.20240717. Any updates when we should expect new images to be published?

@mboersma
Copy link
Contributor Author

@desek the CAPZ team stopped publishing reference images to the Azure Marketplace last fall, when #5167 was merged. Instead, we use a Community Gallery now.

See the docs at https://capz.sigs.k8s.io/self-managed/custom-images and please follow up here or in Slack if you have more questions.

@nawazkh nawazkh added this to the v1.20 milestone Apr 10, 2025
@nawazkh nawazkh assigned nawazkh and mboersma and unassigned nawazkh May 8, 2025
@mboersma mboersma linked a pull request May 12, 2025 that will close this issue
Draft
4 tasks
@mboersma mboersma moved this from Todo to In Progress in CAPZ Planning May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mboersma mboersma

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
CAPZ Planning
Status: In Progress
Milestone
v1.20
Development

Successfully merging a pull request may close this issue.

[WIP] Default to windows-2025 community gallery images mboersma/cluster-api-provider-azure
5 participants
@mboersma @jsturtevant @desek @k8s-ci-robot @nawazkh