Skip to content

Commit 0359b94

Browse files
committed
Fix conversion-gen
Signed-off-by: Hans Rakers <[email protected]>
1 parent 57c895a commit 0359b94

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

Makefile

+9-6
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ GH_REPO ?= kubernetes-sigs/cluster-api-provider-cloudstack
2727

2828
# Binaries
2929
CONTROLLER_GEN := $(TOOLS_BIN_DIR)/controller-gen
30+
CONVERSION_GEN := $(TOOLS_BIN_DIR)/conversion-gen
3031
GINKGO := $(TOOLS_BIN_DIR)/ginkgo
3132
GOLANGCI_LINT := $(TOOLS_BIN_DIR)/golangci-lint
3233
KUSTOMIZE := $(TOOLS_BIN_DIR)/kustomize
@@ -80,7 +81,7 @@ all: build
8081
## --------------------------------------
8182

8283
.PHONY: binaries
83-
binaries: $(CONTROLLER_GEN) $(GOLANGCI_LINT) $(STATIC_CHECK) $(GINKGO) $(MOCKGEN) $(KUSTOMIZE) managers # Builds and installs all binaries
84+
binaries: $(CONTROLLER_GEN) $(CONVERSION_GEN) $(GOLANGCI_LINT) $(STATIC_CHECK) $(GINKGO) $(MOCKGEN) $(KUSTOMIZE) managers # Builds and installs all binaries
8485

8586
.PHONY: managers
8687
managers:
@@ -158,12 +159,14 @@ config/.flag.mk: $(CONTROLLER_GEN) $(MANIFEST_GEN_INPUTS)
158159
@touch config/.flag.mk
159160

160161
CONVERSION_GEN_TARGET=$(shell find api -type d -name "v*1" -exec echo {}\/zz_generated.conversion.go \;)
161-
CONVERSION_GEN_INPUTS=$(shell find ./api -name "*test*" -prune -o -name "*zz_generated*" -prune -o -type f -print)
162162
.PHONY: generate-conversion
163-
generate-conversion: $(CONVERSION_GEN_TARGET) ## Generate code to convert api/v1beta1 to api/v1beta2
164-
api/%/zz_generated.conversion.go: bin/conversion-gen $(CONVERSION_GEN_INPUTS)
165-
conversion-gen --go-header-file "./hack/boilerplate.go.txt" --input-dirs "./api/v1beta1" \
166-
--output-base "." --output-file-base="zz_generated.conversion" --skip-unsafe=true
163+
generate-conversion: $(CONTROLLER_GEN) ## Generate code to convert api/v1beta1 and api/v1beta2 to api/v1beta3
164+
$(CONVERSION_GEN) \
165+
--input-dirs=./api/v1beta1 \
166+
--input-dirs=./api/v1beta2 \
167+
--extra-peer-dirs=sigs.k8s.io/cluster-api/api/v1beta1 \
168+
--go-header-file=./hack/boilerplate.go.txt \
169+
--output-base=. --output-file-base=zz_generated.conversion
167170

168171
##@ Build
169172
## --------------------------------------

0 commit comments

Comments
 (0)