Update controllers/ibmpowervsmachine_controller.go

carmal891 · Karthik-K-N · web-flow · commit 368001b2f031 · 2024-10-23T13:15:04.000+05:30
error message improvements

Co-authored-by: Karthik Bhat &lt;karthikkn1997@gmail.com&gt;
diff --git a/controllers/ibmpowervsmachine_controller.go b/controllers/ibmpowervsmachine_controller.go
@@ -202,7 +202,7 @@ func (r *IBMPowerVSMachineReconciler) getOrCreate(scope *scope.PowerVSMachineSco
 func (r *IBMPowerVSMachineReconciler) handleLoadBalancerPoolMemberConfiguration(machineScope *scope.PowerVSMachineScope) (ctrl.Result, error) {
 	poolMember, err := machineScope.CreateVPCLoadBalancerPoolMember()
 	if err != nil {
-		return ctrl.Result{}, fmt.Errorf("failed CreateVPCLoadBalancerPoolMember %s: %w", machineScope.IBMPowerVSMachine.Name, err)
+		return ctrl.Result{}, fmt.Errorf("failed to create loadbalancer pool member %s: %w", machineScope.IBMPowerVSMachine.Name, err)
 	}
 	if poolMember != nil && *poolMember.ProvisioningStatus != string(infrav1beta2.VPCLoadBalancerStateActive) {
 		return ctrl.Result{RequeueAfter: 1 * time.Minute}, nil

Original file line number	Diff line number	Diff line change
`@@ -202,7 +202,7 @@ func (r IBMPowerVSMachineReconciler) getOrCreate(scope scope.PowerVSMachineSco`
`202`	`202`	`func (r IBMPowerVSMachineReconciler) handleLoadBalancerPoolMemberConfiguration(machineScope scope.PowerVSMachineScope) (ctrl.Result, error) {`
`203`	`203`	`poolMember, err := machineScope.CreateVPCLoadBalancerPoolMember()`
`204`	`204`	`if err != nil {`
`205`		`- return ctrl.Result{}, fmt.Errorf("failed CreateVPCLoadBalancerPoolMember %s: %w", machineScope.IBMPowerVSMachine.Name, err)`
	`205`	`+ return ctrl.Result{}, fmt.Errorf("failed to create loadbalancer pool member %s: %w", machineScope.IBMPowerVSMachine.Name, err)`
`206`	`206`	`}`
`207`	`207`	`if poolMember != nil && *poolMember.ProvisioningStatus != string(infrav1beta2.VPCLoadBalancerStateActive) {`
`208`	`208`	`return ctrl.Result{RequeueAfter: 1 * time.Minute}, nil`