Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update references to provider-id format in documentation #2166

Closed
Amulyam24 opened this issue Feb 4, 2025 · 5 comments
Closed

Update references to provider-id format in documentation #2166

Amulyam24 opened this issue Feb 4, 2025 · 5 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Milestone

Comments

@Amulyam24
Copy link
Contributor

Recently, the provider ID format version v1 has been deprecated via #2122. By default, we set the version as v2 in the manager. Update the documentation for not setting it additionally as it is not required.

@Amulyam24
Copy link
Contributor Author

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@Amulyam24:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Feb 4, 2025
@pjsharath28
Copy link
Contributor

/assign

@mkumatag mkumatag added this to the v0.10.0 milestone Feb 4, 2025
@Prajyot-Parab
Copy link
Contributor

@Amulyam24 I think this can be handled via #2168 itself, please drop your review comments there.
thanks!

@Amulyam24
Copy link
Contributor Author

Handled via #2168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

No branches or pull requests

5 participants