Skip to content

Refactor reconcileNormal function to accept context from caller #2018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
carmal891 opened this issue Oct 21, 2024 · 3 comments
Closed

Refactor reconcileNormal function to accept context from caller #2018

carmal891 opened this issue Oct 21, 2024 · 3 comments
Assignees
@carmal891
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/bug Categorizes issue or PR as related to a bug.
Milestone
v0.11.0

Comments

@carmal891
Copy link
Contributor

carmal891 commented Oct 21, 2024 •
edited
Loading

/kind bug
/area provider/ibmcloud

What steps did you take and what happened:
Refactor the existing reconcileNormal function to accept a context parameter from the caller.

  1. The new function signature should be:
    reconcileNormal(ctx context.Context, machineScope *scope.PowerVSMachineScope)

  2. Update logs to use contextual logging with appropriate verbosity level - https://cluster-api.sigs.k8s.io/developer/logging#contextual-logging

  3. All code sections where reconcileNormal is invoked must also be updated accordingly

What did you expect to happen:

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Cluster-api version:
  • Minikube/KIND version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. area/provider/ibmcloud Issues or PRs related to ibmcloud provider labels Oct 21, 2024
@carmal891 carmal891 mentioned this issue Oct 21, 2024
Merged
@carmal891
Copy link
Contributor Author

/assign

@mkumatag mkumatag added this to the Next milestone Oct 29, 2024
@mkumatag mkumatag modified the milestones: Next, v0.10.0 Jan 7, 2025
@mkumatag mkumatag modified the milestones: v0.10.0, v0.11.0 Feb 12, 2025
@carmal891 carmal891 mentioned this issue Feb 24, 2025
Closed
@Karthik-K-N
Copy link
Contributor

/close

We have umbrella issue, Which takes care of other things needs to be completed for a controller #2129

@k8s-ci-robot
Copy link
Contributor

@Karthik-K-N: Closing this issue.

In response to this:

/close

We have umbrella issue, Which takes care of other things needs to be completed for a controller #2129

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carmal891 carmal891

Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
v0.11.0
4 participants
@mkumatag @k8s-ci-robot @Karthik-K-N @carmal891