🐛 Fix multiline Ready condition in clusterctl describe for v1beta2 #11781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
tobiasgiese
commented
Feb 1, 2025
Comment on lines
338
to
334
| "Object/root", | ||
| "│ 2", | ||
| "├─Object/child1", | ||
| "│ 2", | ||
| "└─Object/child2", |
There was a problem hiding this comment.
Without the fix (where ? is no prefix)
Object/root Available: False NotAvailable 292y 1
? 2
├─Object/child1 Available: False NotAvailable 292y 1
│ 2
└─Object/child2 Available: False NotAvailable 292y 1
2
tobiasgiese
commented
Feb 1, 2025
Comment on lines
382
to
373
| "Object/root", | ||
| "├─Object/child1", | ||
| "└─Object/child2", | ||
| " │ 2", | ||
| " └─Object/child2.1", |
There was a problem hiding this comment.
Without the fix
Object/root Available: True Available 292y
├─Object/child1 Available: True Available 292y
└─Object/child2 Available: False NotAvailable 292y 1
2
└─Object/child2.1
tobiasgiese
force-pushed
the
fix-multiline-parent-conditions-tests
branch
4 times, most recently
from
7f71cbc to
79b13f5
Compare
tobiasgiese
changed the title
tobiasgiese
force-pushed
the
fix-multiline-parent-conditions-tests
branch
5 times, most recently
from
c8bfa74 to
8c38475
Compare
tobiasgiese
commented
Feb 2, 2025
Comment on lines
451
to
511
| "Object/root", | ||
| "├─Object/child1", | ||
| "├─Object/child2", | ||
| "│ │ 2", | ||
| "│ └─Object/child2.1", | ||
| "│ 2", | ||
| "└─Object/child3", | ||
| " │ 2", | ||
| " └─Object/child3.1", | ||
| " 2", |
There was a problem hiding this comment.
Without the fix
Object/root Available: True Available 292y
├─Object/child1 Available: True Available 292y
├─Object/child2 Available: False NotAvailable 292y 1
│ 2
│ └─Object/child2.1 Available: False NotAvailable 292y 1
│ 2
└─Object/child3 Available: False NotAvailable 292y 1
2
└─Object/child3.1 Available: False NotAvailable 292y 1
2
ac341c5 to
3aa0b3b
Compare
|
/assign @fabriziopandini |
tobiasgiese
force-pushed
the
fix-multiline-parent-conditions-tests
branch
from
3aa0b3b to
eac73ac
Compare
tobiasgiese
force-pushed
the
fix-multiline-parent-conditions-tests
branch
from
eac73ac to
3c489c9
Compare
There was a problem hiding this comment.
@tobiasgiese sorry for the delay in the review, there is one last comment to be addressed, otherwise lgtm
tobiasgiese
force-pushed
the
fix-multiline-parent-conditions-tests
branch
2 times, most recently
from
dcc6b19 to
b7e974d
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: f8a357a7703d2c8f38dad47ea1671b365373f10e
|
tobiasgiese
force-pushed
the
fix-multiline-parent-conditions-tests
branch
from
cc6f12f to
a47ec12
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 5ed2ac4eff00984cb871692cb7c3e22daffda18a
|
|
Found a bug in the |
sbueringer
reviewed
Mar 5, 2025
tobiasgiese
force-pushed
the
fix-multiline-parent-conditions-tests
branch
from
a47ec12 to
bae3138
Compare
k8s-ci-robot
removed
the
lgtm
tobiasgiese
force-pushed
the
fix-multiline-parent-conditions-tests
branch
4 times, most recently
from
8bd5cc1 to
f7cad30
Compare
sbueringer
reviewed
Mar 5, 2025
tobiasgiese
force-pushed
the
fix-multiline-parent-conditions-tests
branch
from
f7cad30 to
9cabfd2
Compare
The multiline feature in clusterctl has a bug in the multiline conditions. If the Ready condition message has multipile lines the multiline prefix is not calculated properly. To fix this we have to add a new logic to determine the multiline prefix for objects. Signed-off-by: Tobias Giese <[email protected]> Co-authored-by: fabriziopandini <[email protected]>
tobiasgiese
force-pushed
the
fix-multiline-parent-conditions-tests
branch
from
9cabfd2 to
4470114
Compare
|
Thank you very much!! /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 4849170499ad48901da0346ea3078999813c756a
|
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The multiline feature in clusterctl has a bug in the multiline conditions.
If the Ready condition message has multipile lines the multiline prefix is not calculated properly.
To fix this we have to add a new logic to determine the multiline prefix for objects.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #11782
/area clusterctl