-
Notifications
You must be signed in to change notification settings - Fork 1.2k
/
Copy pathcontroller_test.go
1329 lines (1108 loc) · 44 KB
/
controller_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
/*
Copyright 2018 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package controller
import (
"context"
"errors"
"fmt"
"sync"
"time"
"github.com/go-logr/logr"
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
"github.com/prometheus/client_golang/prometheus"
dto "github.com/prometheus/client_model/go"
appsv1 "k8s.io/api/apps/v1"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
"k8s.io/client-go/util/workqueue"
"k8s.io/utils/ptr"
"sigs.k8s.io/controller-runtime/pkg/cache"
"sigs.k8s.io/controller-runtime/pkg/cache/informertest"
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/controller/controllertest"
"sigs.k8s.io/controller-runtime/pkg/controller/priorityqueue"
"sigs.k8s.io/controller-runtime/pkg/event"
"sigs.k8s.io/controller-runtime/pkg/handler"
ctrlmetrics "sigs.k8s.io/controller-runtime/pkg/internal/controller/metrics"
"sigs.k8s.io/controller-runtime/pkg/internal/log"
"sigs.k8s.io/controller-runtime/pkg/reconcile"
"sigs.k8s.io/controller-runtime/pkg/source"
)
type TestRequest struct {
Key string
}
var _ = Describe("controller", func() {
var fakeReconcile *fakeReconciler
var ctrl *Controller[reconcile.Request]
var queue *controllertest.Queue
var reconciled chan reconcile.Request
var request = reconcile.Request{
NamespacedName: types.NamespacedName{Namespace: "foo", Name: "bar"},
}
BeforeEach(func() {
reconciled = make(chan reconcile.Request)
fakeReconcile = &fakeReconciler{
Requests: reconciled,
results: make(chan fakeReconcileResultPair, 10 /* chosen by the completely scientific approach of guessing */),
}
queue = &controllertest.Queue{
TypedInterface: workqueue.NewTyped[reconcile.Request](),
}
ctrl = &Controller[reconcile.Request]{
MaxConcurrentReconciles: 1,
Do: fakeReconcile,
NewQueue: func(string, workqueue.TypedRateLimiter[reconcile.Request]) workqueue.TypedRateLimitingInterface[reconcile.Request] {
return queue
},
LogConstructor: func(_ *reconcile.Request) logr.Logger {
return log.RuntimeLog.WithName("controller").WithName("test")
},
}
})
Describe("Reconciler", func() {
It("should call the Reconciler function", func() {
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
ctrl.Do = reconcile.Func(func(context.Context, reconcile.Request) (reconcile.Result, error) {
return reconcile.Result{Requeue: true}, nil
})
result, err := ctrl.Reconcile(ctx,
reconcile.Request{NamespacedName: types.NamespacedName{Namespace: "foo", Name: "bar"}})
Expect(err).NotTo(HaveOccurred())
Expect(result).To(Equal(reconcile.Result{Requeue: true}))
})
It("should not recover panic if RecoverPanic is false", func() {
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
defer func() {
Expect(recover()).ShouldNot(BeNil())
}()
ctrl.RecoverPanic = ptr.To(false)
ctrl.Do = reconcile.Func(func(context.Context, reconcile.Request) (reconcile.Result, error) {
var res *reconcile.Result
return *res, nil
})
_, _ = ctrl.Reconcile(ctx,
reconcile.Request{NamespacedName: types.NamespacedName{Namespace: "foo", Name: "bar"}})
})
It("should recover panic if RecoverPanic is true by default", func() {
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
defer func() {
Expect(recover()).To(BeNil())
}()
// RecoverPanic defaults to true.
ctrl.Do = reconcile.Func(func(context.Context, reconcile.Request) (reconcile.Result, error) {
var res *reconcile.Result
return *res, nil
})
_, err := ctrl.Reconcile(ctx,
reconcile.Request{NamespacedName: types.NamespacedName{Namespace: "foo", Name: "bar"}})
Expect(err).To(HaveOccurred())
Expect(err.Error()).To(ContainSubstring("[recovered]"))
})
It("should recover panic if RecoverPanic is true", func() {
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
defer func() {
Expect(recover()).To(BeNil())
}()
ctrl.RecoverPanic = ptr.To(true)
ctrl.Do = reconcile.Func(func(context.Context, reconcile.Request) (reconcile.Result, error) {
var res *reconcile.Result
return *res, nil
})
_, err := ctrl.Reconcile(ctx,
reconcile.Request{NamespacedName: types.NamespacedName{Namespace: "foo", Name: "bar"}})
Expect(err).To(HaveOccurred())
Expect(err.Error()).To(ContainSubstring("[recovered]"))
})
})
Describe("Start", func() {
It("should return an error if there is an error waiting for the informers", func() {
ctrl.CacheSyncTimeout = time.Second
f := false
ctrl.startWatches = []source.TypedSource[reconcile.Request]{
source.Kind(&informertest.FakeInformers{Synced: &f}, &corev1.Pod{}, &handler.TypedEnqueueRequestForObject[*corev1.Pod]{}),
}
ctrl.Name = "foo"
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
err := ctrl.Start(ctx)
Expect(err).To(HaveOccurred())
Expect(err.Error()).To(ContainSubstring("failed to wait for foo caches to sync"))
})
It("should error when cache sync timeout occurs", func() {
c, err := cache.New(cfg, cache.Options{})
Expect(err).NotTo(HaveOccurred())
c = &cacheWithIndefinitelyBlockingGetInformer{c}
ctrl.CacheSyncTimeout = time.Second
ctrl.startWatches = []source.TypedSource[reconcile.Request]{
source.Kind(c, &appsv1.Deployment{}, &handler.TypedEnqueueRequestForObject[*appsv1.Deployment]{}),
}
ctrl.Name = "testcontroller"
err = ctrl.Start(context.TODO())
Expect(err).To(HaveOccurred())
Expect(err.Error()).To(ContainSubstring("failed to wait for testcontroller caches to sync kind source: *v1.Deployment: timed out waiting for cache to be synced"))
})
It("should not error when controller Start context is cancelled during Sources WaitForSync", func() {
ctrl.CacheSyncTimeout = 1 * time.Second
sourceSynced := make(chan struct{})
c, err := cache.New(cfg, cache.Options{})
Expect(err).NotTo(HaveOccurred())
c = &cacheWithIndefinitelyBlockingGetInformer{c}
ctrl.startWatches = []source.TypedSource[reconcile.Request]{
&singnallingSourceWrapper{
SyncingSource: source.Kind[client.Object](c, &appsv1.Deployment{}, &handler.EnqueueRequestForObject{}),
cacheSyncDone: sourceSynced,
},
}
ctrl.Name = "testcontroller"
ctx, cancel := context.WithCancel(context.TODO())
go func() {
defer GinkgoRecover()
err = ctrl.Start(ctx)
Expect(err).To(Succeed())
}()
cancel()
<-sourceSynced
})
It("should error when Start() is blocking forever", func() {
ctrl.CacheSyncTimeout = time.Second
controllerDone := make(chan struct{})
ctrl.startWatches = []source.TypedSource[reconcile.Request]{
source.Func(func(ctx context.Context, _ workqueue.TypedRateLimitingInterface[reconcile.Request]) error {
<-controllerDone
return ctx.Err()
})}
ctx, cancel := context.WithTimeout(context.TODO(), 10*time.Second)
defer cancel()
err := ctrl.Start(ctx)
Expect(err).To(HaveOccurred())
Expect(err.Error()).To(ContainSubstring("Please ensure that its Start() method is non-blocking"))
close(controllerDone)
})
It("should not error when cache sync timeout is of sufficiently high", func() {
ctrl.CacheSyncTimeout = 10 * time.Second
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
sourceSynced := make(chan struct{})
c := &informertest.FakeInformers{}
ctrl.startWatches = []source.TypedSource[reconcile.Request]{
&singnallingSourceWrapper{
SyncingSource: source.Kind[client.Object](c, &appsv1.Deployment{}, &handler.EnqueueRequestForObject{}),
cacheSyncDone: sourceSynced,
},
}
go func() {
defer GinkgoRecover()
Expect(ctrl.Start(ctx)).To(Succeed())
}()
<-sourceSynced
})
It("should process events from source.Channel", func() {
ctrl.CacheSyncTimeout = 10 * time.Second
// channel to be closed when event is processed
processed := make(chan struct{})
// source channel
ch := make(chan event.GenericEvent, 1)
ctx, cancel := context.WithCancel(context.TODO())
defer cancel()
// event to be sent to the channel
p := &corev1.Pod{
ObjectMeta: metav1.ObjectMeta{Name: "foo", Namespace: "bar"},
}
evt := event.GenericEvent{
Object: p,
}
ins := source.Channel(
ch,
handler.Funcs{
GenericFunc: func(ctx context.Context, evt event.GenericEvent, q workqueue.TypedRateLimitingInterface[reconcile.Request]) {
defer GinkgoRecover()
close(processed)
},
},
)
// send the event to the channel
ch <- evt
ctrl.startWatches = []source.TypedSource[reconcile.Request]{ins}
go func() {
defer GinkgoRecover()
Expect(ctrl.Start(ctx)).To(Succeed())
}()
<-processed
})
It("should error when channel source is not specified", func() {
ctrl.CacheSyncTimeout = 10 * time.Second
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
ins := source.Channel[string](nil, nil)
ctrl.startWatches = []source.TypedSource[reconcile.Request]{ins}
e := ctrl.Start(ctx)
Expect(e).To(HaveOccurred())
Expect(e.Error()).To(ContainSubstring("must specify Channel.Source"))
})
It("should call Start on sources with the appropriate EventHandler, Queue, and Predicates", func() {
ctrl.CacheSyncTimeout = 10 * time.Second
started := false
ctx, cancel := context.WithCancel(context.Background())
src := source.Func(func(ctx context.Context, q workqueue.TypedRateLimitingInterface[reconcile.Request]) error {
defer GinkgoRecover()
Expect(q).To(Equal(ctrl.Queue))
started = true
cancel() // Cancel the context so ctrl.Start() doesn't block forever
return nil
})
Expect(ctrl.Watch(src)).NotTo(HaveOccurred())
err := ctrl.Start(ctx)
Expect(err).To(Succeed())
Expect(started).To(BeTrue())
})
It("should return an error if there is an error starting sources", func() {
ctrl.CacheSyncTimeout = 10 * time.Second
err := fmt.Errorf("Expected Error: could not start source")
src := source.Func(func(context.Context,
workqueue.TypedRateLimitingInterface[reconcile.Request],
) error {
defer GinkgoRecover()
return err
})
Expect(ctrl.Watch(src)).To(Succeed())
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
Expect(ctrl.Start(ctx)).To(Equal(err))
})
It("should return an error if it gets started more than once", func() {
// Use a cancelled context so Start doesn't block
ctx, cancel := context.WithCancel(context.Background())
cancel()
Expect(ctrl.Start(ctx)).To(Succeed())
err := ctrl.Start(ctx)
Expect(err).To(HaveOccurred())
Expect(err.Error()).To(Equal("controller was started more than once. This is likely to be caused by being added to a manager multiple times"))
})
It("should check for correct TypedSyncingSource if custom types are used", func() {
queue := &priorityQueueWrapper[TestRequest]{
TypedRateLimitingInterface: &controllertest.TypedQueue[TestRequest]{
TypedInterface: workqueue.NewTyped[TestRequest](),
}}
ctrl := &Controller[TestRequest]{
NewQueue: func(string, workqueue.TypedRateLimiter[TestRequest]) workqueue.TypedRateLimitingInterface[TestRequest] {
return queue
},
LogConstructor: func(*TestRequest) logr.Logger {
return log.RuntimeLog.WithName("controller").WithName("test")
},
}
ctrl.CacheSyncTimeout = time.Second
src := &bisignallingSource[TestRequest]{
startCall: make(chan workqueue.TypedRateLimitingInterface[TestRequest]),
startDone: make(chan error, 1),
waitCall: make(chan struct{}),
waitDone: make(chan error, 1),
}
ctrl.startWatches = []source.TypedSource[TestRequest]{src}
ctrl.Name = "foo"
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
startCh := make(chan error)
go func() {
defer GinkgoRecover()
startCh <- ctrl.Start(ctx)
}()
Eventually(src.startCall).Should(Receive(Equal(queue)))
src.startDone <- nil
Eventually(src.waitCall).Should(BeClosed())
src.waitDone <- nil
cancel()
Eventually(startCh).Should(Receive(Succeed()))
})
})
Describe("startEventSources", func() {
It("should return nil when no sources are provided", func() {
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
ctrl.startWatches = []source.TypedSource[reconcile.Request]{}
err := ctrl.startEventSources(ctx)
Expect(err).NotTo(HaveOccurred())
})
It("should return an error if a source fails to start", func() {
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
expectedErr := fmt.Errorf("failed to start source")
src := source.Func(func(ctx context.Context, _ workqueue.TypedRateLimitingInterface[reconcile.Request]) error {
// Return the error immediately so we don't get a timeout
return expectedErr
})
// Set a sufficiently long timeout to avoid timeouts interfering with the error being returned
ctrl.CacheSyncTimeout = 5 * time.Second
ctrl.startWatches = []source.TypedSource[reconcile.Request]{src}
err := ctrl.startEventSources(ctx)
Expect(err).To(Equal(expectedErr))
})
It("should return an error if a source fails to sync", func() {
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
ctrl.startWatches = []source.TypedSource[reconcile.Request]{
source.Kind(&informertest.FakeInformers{Synced: ptr.To(false)}, &corev1.Pod{}, &handler.TypedEnqueueRequestForObject[*corev1.Pod]{}),
}
ctrl.Name = "test-controller"
ctrl.CacheSyncTimeout = 5 * time.Second
err := ctrl.startEventSources(ctx)
Expect(err).To(HaveOccurred())
Expect(err.Error()).To(ContainSubstring("failed to wait for test-controller caches to sync"))
})
It("should not return an error when sources start and sync successfully", func() {
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
// Create a source that starts and syncs successfully
ctrl.startWatches = []source.TypedSource[reconcile.Request]{
source.Kind(&informertest.FakeInformers{Synced: ptr.To(true)}, &corev1.Pod{}, &handler.TypedEnqueueRequestForObject[*corev1.Pod]{}),
}
ctrl.Name = "test-controller"
ctrl.CacheSyncTimeout = 5 * time.Second
err := ctrl.startEventSources(ctx)
Expect(err).NotTo(HaveOccurred())
})
It("should not return an error when context is cancelled during source sync", func() {
sourceCtx, sourceCancel := context.WithCancel(context.Background())
defer sourceCancel()
ctrl.CacheSyncTimeout = 5 * time.Second
// Create a bisignallingSource to control the test flow
src := &bisignallingSource[reconcile.Request]{
startCall: make(chan workqueue.TypedRateLimitingInterface[reconcile.Request]),
startDone: make(chan error, 1),
waitCall: make(chan struct{}),
waitDone: make(chan error, 1),
}
ctrl.startWatches = []source.TypedSource[reconcile.Request]{src}
// Start the sources in a goroutine
startErrCh := make(chan error)
go func() {
startErrCh <- ctrl.startEventSources(sourceCtx)
}()
// Allow source to start successfully
Eventually(src.startCall).Should(Receive())
src.startDone <- nil
// Wait for WaitForSync to be called
Eventually(src.waitCall).Should(BeClosed())
// Return context.Canceled from WaitForSync
src.waitDone <- context.Canceled
// Also cancel the context
sourceCancel()
// We expect to receive the context.Canceled error
err := <-startErrCh
Expect(err).To(MatchError(context.Canceled))
})
It("should timeout if source Start blocks for too long", func() {
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
ctrl.CacheSyncTimeout = 1 * time.Millisecond
// Create a source that blocks forever in Start
blockingSrc := source.Func(func(ctx context.Context, _ workqueue.TypedRateLimitingInterface[reconcile.Request]) error {
<-ctx.Done()
return ctx.Err()
})
ctrl.startWatches = []source.TypedSource[reconcile.Request]{blockingSrc}
err := ctrl.startEventSources(ctx)
Expect(err).To(HaveOccurred())
Expect(err.Error()).To(ContainSubstring("timed out waiting for source"))
})
})
Describe("Processing queue items from a Controller", func() {
It("should call Reconciler if an item is enqueued", func() {
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
go func() {
defer GinkgoRecover()
Expect(ctrl.Start(ctx)).NotTo(HaveOccurred())
}()
queue.Add(request)
By("Invoking Reconciler")
fakeReconcile.AddResult(reconcile.Result{}, nil)
Expect(<-reconciled).To(Equal(request))
By("Removing the item from the queue")
Eventually(queue.Len).Should(Equal(0))
Eventually(func() int { return queue.NumRequeues(request) }).Should(Equal(0))
})
It("should requeue a Request if there is an error and continue processing items", func() {
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
go func() {
defer GinkgoRecover()
Expect(ctrl.Start(ctx)).NotTo(HaveOccurred())
}()
queue.Add(request)
By("Invoking Reconciler which will give an error")
fakeReconcile.AddResult(reconcile.Result{}, fmt.Errorf("expected error: reconcile"))
Expect(<-reconciled).To(Equal(request))
queue.AddedRateLimitedLock.Lock()
Expect(queue.AddedRatelimited).To(Equal([]any{request}))
queue.AddedRateLimitedLock.Unlock()
By("Invoking Reconciler a second time without error")
fakeReconcile.AddResult(reconcile.Result{}, nil)
Expect(<-reconciled).To(Equal(request))
By("Removing the item from the queue")
Eventually(queue.Len).Should(Equal(0))
Eventually(func() int { return queue.NumRequeues(request) }, 1.0).Should(Equal(0))
})
It("should not requeue a Request if there is a terminal error", func() {
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
go func() {
defer GinkgoRecover()
Expect(ctrl.Start(ctx)).NotTo(HaveOccurred())
}()
queue.Add(request)
By("Invoking Reconciler which will give an error")
fakeReconcile.AddResult(reconcile.Result{}, reconcile.TerminalError(fmt.Errorf("expected error: reconcile")))
Expect(<-reconciled).To(Equal(request))
queue.AddedRateLimitedLock.Lock()
Expect(queue.AddedRatelimited).To(BeEmpty())
queue.AddedRateLimitedLock.Unlock()
Expect(queue.Len()).Should(Equal(0))
})
// TODO(directxman12): we should ensure that backoff occurrs with error requeue
It("should not reset backoff until there's a non-error result", func() {
dq := &DelegatingQueue{TypedRateLimitingInterface: ctrl.NewQueue("controller1", nil)}
ctrl.NewQueue = func(string, workqueue.TypedRateLimiter[reconcile.Request]) workqueue.TypedRateLimitingInterface[reconcile.Request] {
return dq
}
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
go func() {
defer GinkgoRecover()
Expect(ctrl.Start(ctx)).NotTo(HaveOccurred())
}()
dq.Add(request)
Expect(dq.getCounts()).To(Equal(countInfo{Trying: 1}))
By("Invoking Reconciler which returns an error")
fakeReconcile.AddResult(reconcile.Result{}, fmt.Errorf("something's wrong"))
Expect(<-reconciled).To(Equal(request))
Eventually(dq.getCounts).Should(Equal(countInfo{Trying: 1, AddRateLimited: 1}))
By("Invoking Reconciler a second time with an error")
fakeReconcile.AddResult(reconcile.Result{}, fmt.Errorf("another thing's wrong"))
Expect(<-reconciled).To(Equal(request))
Eventually(dq.getCounts).Should(Equal(countInfo{Trying: 1, AddRateLimited: 2}))
By("Invoking Reconciler a third time, where it finally does not return an error")
fakeReconcile.AddResult(reconcile.Result{}, nil)
Expect(<-reconciled).To(Equal(request))
Eventually(dq.getCounts).Should(Equal(countInfo{Trying: 0, AddRateLimited: 2}))
By("Removing the item from the queue")
Eventually(dq.Len).Should(Equal(0))
Eventually(func() int { return dq.NumRequeues(request) }).Should(Equal(0))
})
It("should requeue a Request with rate limiting if the Result sets Requeue:true and continue processing items", func() {
dq := &DelegatingQueue{TypedRateLimitingInterface: ctrl.NewQueue("controller1", nil)}
ctrl.NewQueue = func(string, workqueue.TypedRateLimiter[reconcile.Request]) workqueue.TypedRateLimitingInterface[reconcile.Request] {
return dq
}
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
go func() {
defer GinkgoRecover()
Expect(ctrl.Start(ctx)).NotTo(HaveOccurred())
}()
dq.Add(request)
Expect(dq.getCounts()).To(Equal(countInfo{Trying: 1}))
By("Invoking Reconciler which will ask for requeue")
fakeReconcile.AddResult(reconcile.Result{Requeue: true}, nil)
Expect(<-reconciled).To(Equal(request))
Eventually(dq.getCounts).Should(Equal(countInfo{Trying: 1, AddRateLimited: 1}))
By("Invoking Reconciler a second time without asking for requeue")
fakeReconcile.AddResult(reconcile.Result{Requeue: false}, nil)
Expect(<-reconciled).To(Equal(request))
Eventually(dq.getCounts).Should(Equal(countInfo{Trying: 0, AddRateLimited: 1}))
By("Removing the item from the queue")
Eventually(dq.Len).Should(Equal(0))
Eventually(func() int { return dq.NumRequeues(request) }).Should(Equal(0))
})
It("should retain the priority when the reconciler requests a requeue", func() {
q := &fakePriorityQueue{PriorityQueue: priorityqueue.New[reconcile.Request]("controller1")}
ctrl.NewQueue = func(string, workqueue.TypedRateLimiter[reconcile.Request]) workqueue.TypedRateLimitingInterface[reconcile.Request] {
return q
}
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
go func() {
defer GinkgoRecover()
Expect(ctrl.Start(ctx)).NotTo(HaveOccurred())
}()
q.PriorityQueue.AddWithOpts(priorityqueue.AddOpts{Priority: 10}, request)
By("Invoking Reconciler which will request a requeue")
fakeReconcile.AddResult(reconcile.Result{Requeue: true}, nil)
Expect(<-reconciled).To(Equal(request))
Eventually(func() []priorityQueueAddition {
q.lock.Lock()
defer q.lock.Unlock()
return q.added
}).Should(Equal([]priorityQueueAddition{{
AddOpts: priorityqueue.AddOpts{
RateLimited: true,
Priority: 10,
},
items: []reconcile.Request{request},
}}))
})
It("should requeue a Request after a duration (but not rate-limitted) if the Result sets RequeueAfter (regardless of Requeue)", func() {
dq := &DelegatingQueue{TypedRateLimitingInterface: ctrl.NewQueue("controller1", nil)}
ctrl.NewQueue = func(string, workqueue.TypedRateLimiter[reconcile.Request]) workqueue.TypedRateLimitingInterface[reconcile.Request] {
return dq
}
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
go func() {
defer GinkgoRecover()
Expect(ctrl.Start(ctx)).NotTo(HaveOccurred())
}()
dq.Add(request)
Expect(dq.getCounts()).To(Equal(countInfo{Trying: 1}))
By("Invoking Reconciler which will ask for requeue & requeueafter")
fakeReconcile.AddResult(reconcile.Result{RequeueAfter: time.Millisecond * 100, Requeue: true}, nil)
Expect(<-reconciled).To(Equal(request))
Eventually(dq.getCounts).Should(Equal(countInfo{Trying: 0, AddAfter: 1}))
By("Invoking Reconciler a second time asking for a requeueafter only")
fakeReconcile.AddResult(reconcile.Result{RequeueAfter: time.Millisecond * 100}, nil)
Expect(<-reconciled).To(Equal(request))
Eventually(dq.getCounts).Should(Equal(countInfo{Trying: -1 /* we don't increment the count in addafter */, AddAfter: 2}))
By("Removing the item from the queue")
Eventually(dq.Len).Should(Equal(0))
Eventually(func() int { return dq.NumRequeues(request) }).Should(Equal(0))
})
It("should retain the priority with RequeAfter", func() {
q := &fakePriorityQueue{PriorityQueue: priorityqueue.New[reconcile.Request]("controller1")}
ctrl.NewQueue = func(string, workqueue.TypedRateLimiter[reconcile.Request]) workqueue.TypedRateLimitingInterface[reconcile.Request] {
return q
}
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
go func() {
defer GinkgoRecover()
Expect(ctrl.Start(ctx)).NotTo(HaveOccurred())
}()
q.PriorityQueue.AddWithOpts(priorityqueue.AddOpts{Priority: 10}, request)
By("Invoking Reconciler which will ask for RequeueAfter")
fakeReconcile.AddResult(reconcile.Result{RequeueAfter: time.Millisecond * 100}, nil)
Expect(<-reconciled).To(Equal(request))
Eventually(func() []priorityQueueAddition {
q.lock.Lock()
defer q.lock.Unlock()
return q.added
}).Should(Equal([]priorityQueueAddition{{
AddOpts: priorityqueue.AddOpts{
After: time.Millisecond * 100,
Priority: 10,
},
items: []reconcile.Request{request},
}}))
})
It("should perform error behavior if error is not nil, regardless of RequeueAfter", func() {
dq := &DelegatingQueue{TypedRateLimitingInterface: ctrl.NewQueue("controller1", nil)}
ctrl.NewQueue = func(string, workqueue.TypedRateLimiter[reconcile.Request]) workqueue.TypedRateLimitingInterface[reconcile.Request] {
return dq
}
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
go func() {
defer GinkgoRecover()
Expect(ctrl.Start(ctx)).NotTo(HaveOccurred())
}()
dq.Add(request)
Expect(dq.getCounts()).To(Equal(countInfo{Trying: 1}))
By("Invoking Reconciler which will ask for requeueafter with an error")
fakeReconcile.AddResult(reconcile.Result{RequeueAfter: time.Millisecond * 100}, fmt.Errorf("expected error: reconcile"))
Expect(<-reconciled).To(Equal(request))
Eventually(dq.getCounts).Should(Equal(countInfo{Trying: 1, AddRateLimited: 1}))
By("Invoking Reconciler a second time asking for requeueafter without errors")
fakeReconcile.AddResult(reconcile.Result{RequeueAfter: time.Millisecond * 100}, nil)
Expect(<-reconciled).To(Equal(request))
Eventually(dq.getCounts).Should(Equal(countInfo{AddAfter: 1, AddRateLimited: 1}))
By("Removing the item from the queue")
Eventually(dq.Len).Should(Equal(0))
Eventually(func() int { return dq.NumRequeues(request) }).Should(Equal(0))
})
It("should retain the priority when there was an error", func() {
q := &fakePriorityQueue{PriorityQueue: priorityqueue.New[reconcile.Request]("controller1")}
ctrl.NewQueue = func(string, workqueue.TypedRateLimiter[reconcile.Request]) workqueue.TypedRateLimitingInterface[reconcile.Request] {
return q
}
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
go func() {
defer GinkgoRecover()
Expect(ctrl.Start(ctx)).NotTo(HaveOccurred())
}()
q.PriorityQueue.AddWithOpts(priorityqueue.AddOpts{Priority: 10}, request)
By("Invoking Reconciler which will return an error")
fakeReconcile.AddResult(reconcile.Result{}, errors.New("oups, I did it again"))
Expect(<-reconciled).To(Equal(request))
Eventually(func() []priorityQueueAddition {
q.lock.Lock()
defer q.lock.Unlock()
return q.added
}).Should(Equal([]priorityQueueAddition{{
AddOpts: priorityqueue.AddOpts{
RateLimited: true,
Priority: 10,
},
items: []reconcile.Request{request},
}}))
})
PIt("should return if the queue is shutdown", func() {
// TODO(community): write this test
})
PIt("should wait for informers to be synced before processing items", func() {
// TODO(community): write this test
})
PIt("should create a new go routine for MaxConcurrentReconciles", func() {
// TODO(community): write this test
})
Context("prometheus metric reconcile_total", func() {
var reconcileTotal dto.Metric
BeforeEach(func() {
ctrlmetrics.ReconcileTotal.Reset()
reconcileTotal.Reset()
})
It("should get updated on successful reconciliation", func() {
Expect(func() error {
Expect(ctrlmetrics.ReconcileTotal.WithLabelValues(ctrl.Name, "success").Write(&reconcileTotal)).To(Succeed())
if reconcileTotal.GetCounter().GetValue() != 0.0 {
return fmt.Errorf("metric reconcile total not reset")
}
return nil
}()).Should(Succeed())
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
go func() {
defer GinkgoRecover()
Expect(ctrl.Start(ctx)).NotTo(HaveOccurred())
}()
By("Invoking Reconciler which will succeed")
queue.Add(request)
fakeReconcile.AddResult(reconcile.Result{}, nil)
Expect(<-reconciled).To(Equal(request))
Eventually(func() error {
Expect(ctrlmetrics.ReconcileTotal.WithLabelValues(ctrl.Name, "success").Write(&reconcileTotal)).To(Succeed())
if actual := reconcileTotal.GetCounter().GetValue(); actual != 1.0 {
return fmt.Errorf("metric reconcile total expected: %v and got: %v", 1.0, actual)
}
return nil
}, 2.0).Should(Succeed())
})
It("should get updated on reconcile errors", func() {
Expect(func() error {
Expect(ctrlmetrics.ReconcileTotal.WithLabelValues(ctrl.Name, "error").Write(&reconcileTotal)).To(Succeed())
if reconcileTotal.GetCounter().GetValue() != 0.0 {
return fmt.Errorf("metric reconcile total not reset")
}
return nil
}()).Should(Succeed())
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
go func() {
defer GinkgoRecover()
Expect(ctrl.Start(ctx)).NotTo(HaveOccurred())
}()
By("Invoking Reconciler which will give an error")
queue.Add(request)
fakeReconcile.AddResult(reconcile.Result{}, fmt.Errorf("expected error: reconcile"))
Expect(<-reconciled).To(Equal(request))
Eventually(func() error {
Expect(ctrlmetrics.ReconcileTotal.WithLabelValues(ctrl.Name, "error").Write(&reconcileTotal)).To(Succeed())
if actual := reconcileTotal.GetCounter().GetValue(); actual != 1.0 {
return fmt.Errorf("metric reconcile total expected: %v and got: %v", 1.0, actual)
}
return nil
}, 2.0).Should(Succeed())
})
It("should get updated when reconcile returns with retry enabled", func() {
Expect(func() error {
Expect(ctrlmetrics.ReconcileTotal.WithLabelValues(ctrl.Name, "retry").Write(&reconcileTotal)).To(Succeed())
if reconcileTotal.GetCounter().GetValue() != 0.0 {
return fmt.Errorf("metric reconcile total not reset")
}
return nil
}()).Should(Succeed())
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
go func() {
defer GinkgoRecover()
Expect(ctrl.Start(ctx)).NotTo(HaveOccurred())
}()
By("Invoking Reconciler which will return result with Requeue enabled")
queue.Add(request)
fakeReconcile.AddResult(reconcile.Result{Requeue: true}, nil)
Expect(<-reconciled).To(Equal(request))
Eventually(func() error {
Expect(ctrlmetrics.ReconcileTotal.WithLabelValues(ctrl.Name, "requeue").Write(&reconcileTotal)).To(Succeed())
if actual := reconcileTotal.GetCounter().GetValue(); actual != 1.0 {
return fmt.Errorf("metric reconcile total expected: %v and got: %v", 1.0, actual)
}
return nil
}, 2.0).Should(Succeed())
})
It("should get updated when reconcile returns with retryAfter enabled", func() {
Expect(func() error {
Expect(ctrlmetrics.ReconcileTotal.WithLabelValues(ctrl.Name, "retry_after").Write(&reconcileTotal)).To(Succeed())
if reconcileTotal.GetCounter().GetValue() != 0.0 {
return fmt.Errorf("metric reconcile total not reset")
}
return nil
}()).Should(Succeed())
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
go func() {
defer GinkgoRecover()
Expect(ctrl.Start(ctx)).NotTo(HaveOccurred())
}()
By("Invoking Reconciler which will return result with requeueAfter enabled")
queue.Add(request)
fakeReconcile.AddResult(reconcile.Result{RequeueAfter: 5 * time.Hour}, nil)
Expect(<-reconciled).To(Equal(request))
Eventually(func() error {
Expect(ctrlmetrics.ReconcileTotal.WithLabelValues(ctrl.Name, "requeue_after").Write(&reconcileTotal)).To(Succeed())
if actual := reconcileTotal.GetCounter().GetValue(); actual != 1.0 {
return fmt.Errorf("metric reconcile total expected: %v and got: %v", 1.0, actual)
}
return nil
}, 2.0).Should(Succeed())
})
})
Context("should update prometheus metrics", func() {
It("should requeue a Request if there is an error and continue processing items", func() {
var reconcileErrs dto.Metric
ctrlmetrics.ReconcileErrors.Reset()
Expect(func() error {
Expect(ctrlmetrics.ReconcileErrors.WithLabelValues(ctrl.Name).Write(&reconcileErrs)).To(Succeed())
if reconcileErrs.GetCounter().GetValue() != 0.0 {
return fmt.Errorf("metric reconcile errors not reset")
}
return nil
}()).Should(Succeed())
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
go func() {
defer GinkgoRecover()
Expect(ctrl.Start(ctx)).NotTo(HaveOccurred())
}()
queue.Add(request)
By("Invoking Reconciler which will give an error")
fakeReconcile.AddResult(reconcile.Result{}, fmt.Errorf("expected error: reconcile"))
Expect(<-reconciled).To(Equal(request))
Eventually(func() error {
Expect(ctrlmetrics.ReconcileErrors.WithLabelValues(ctrl.Name).Write(&reconcileErrs)).To(Succeed())
if reconcileErrs.GetCounter().GetValue() != 1.0 {
return fmt.Errorf("metrics not updated")
}
return nil
}, 2.0).Should(Succeed())
By("Invoking Reconciler a second time without error")
fakeReconcile.AddResult(reconcile.Result{}, nil)
Expect(<-reconciled).To(Equal(request))
By("Removing the item from the queue")
Eventually(queue.Len).Should(Equal(0))
Eventually(func() int { return queue.NumRequeues(request) }).Should(Equal(0))
})
It("should add a reconcile time to the reconcile time histogram", func() {
var reconcileTime dto.Metric
ctrlmetrics.ReconcileTime.Reset()
Expect(func() error {
histObserver := ctrlmetrics.ReconcileTime.WithLabelValues(ctrl.Name)
hist := histObserver.(prometheus.Histogram)
Expect(hist.Write(&reconcileTime)).To(Succeed())
if reconcileTime.GetHistogram().GetSampleCount() != uint64(0) {
return fmt.Errorf("metrics not reset")
}
return nil
}()).Should(Succeed())
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
go func() {
defer GinkgoRecover()
Expect(ctrl.Start(ctx)).NotTo(HaveOccurred())
}()
queue.Add(request)
By("Invoking Reconciler")
fakeReconcile.AddResult(reconcile.Result{}, nil)
Expect(<-reconciled).To(Equal(request))