Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

external-dns 1.15.1 helm chart does not support nodeAffinity anymore #5037

Open
mkhpalm opened this issue Jan 27, 2025 · 1 comment · May be fixed by #5046
Open

external-dns 1.15.1 helm chart does not support nodeAffinity anymore #5037

mkhpalm opened this issue Jan 27, 2025 · 1 comment · May be fixed by #5046
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@mkhpalm
Copy link

mkhpalm commented Jan 27, 2025

What happened:

A change was made to affinity that blocks access to nodeAffinity: 844bab3

What you expected to happen:

To be able to use affinity.nodeAffinity too: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.32/#affinity-v1-core

How to reproduce it (as minimally and precisely as possible):

     # This will be ignored
      affinity:
        nodeAffinity:
          requiredDuringSchedulingIgnoredDuringExecution:
            nodeSelectorTerms:
            - matchExpressions:
              - key: topology.kubernetes.io/zone
                operator: In
                values:
                - zoneA
                - zoneB
@mkhpalm mkhpalm added the kind/bug Categorizes issue or PR as related to a bug. label Jan 27, 2025
@cilindrox
Copy link

This seems to have been broken in #4666 - This bit https://github.com/kubernetes-sigs/external-dns/pull/4666/files#diff-6ad1b3106470e68ead8d0102e9c4db266f63a9ff374104ddfc5c284f7a1945ebL206-R207

missed the {{- with .nodeAffinity }} along with a bunch of others

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants