Skip to content

Commit 50ddf7d

Browse files
shaneuttk8s-ci-robot
authored andcommitted
chore: re-organize conformance test features
1 parent a0caa6d commit 50ddf7d

File tree

1 file changed

+34
-9
lines changed

1 file changed

+34
-9
lines changed

conformance/utils/suite/features.go

Lines changed: 34 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,39 @@ package suite
22

33
import "k8s.io/apimachinery/pkg/util/sets"
44

5+
// -----------------------------------------------------------------------------
6+
// Features - Types
7+
// -----------------------------------------------------------------------------
8+
59
// SupportedFeature allows opting in to additional conformance tests at an
610
// individual feature granularity.
711
type SupportedFeature string
812

13+
// -----------------------------------------------------------------------------
14+
// Features - All Profiles
15+
// -----------------------------------------------------------------------------
16+
917
const (
1018
// This option indicates support for ReferenceGrant (core conformance).
1119
// Opting out of this requires an implementation to have clearly implemented
1220
// and documented equivalent safeguards.
1321
SupportReferenceGrant SupportedFeature = "ReferenceGrant"
1422

15-
// This option indicates support for TLSRoute (extended conformance).
16-
SupportTLSRoute SupportedFeature = "TLSRoute"
23+
// This option indicates GatewayClass will update the observedGeneration in it's conditions when reconciling
24+
SupportGatewayClassObservedGenerationBump SupportedFeature = "GatewayClassObservedGenerationBump"
25+
)
26+
27+
// StandardCoreFeatures are the features that are required to be conformant with
28+
// the Core API features that are part of the Standard release channel.
29+
var StandardCoreFeatures = sets.New(
30+
SupportReferenceGrant,
31+
)
32+
33+
// -----------------------------------------------------------------------------
34+
// Features - HTTP Conformance Profile
35+
// -----------------------------------------------------------------------------
36+
37+
const (
1738

1839
// This option indicates support for HTTPRoute query param matching (extended conformance).
1940
SupportHTTPRouteQueryParamMatching SupportedFeature = "HTTPRouteQueryParamMatching"
@@ -27,9 +48,6 @@ const (
2748
// This option indicates support for Destination Port matching (extended conformance).
2849
SupportRouteDestinationPortMatching SupportedFeature = "RouteDestinationPortMatching"
2950

30-
// This option indicates GatewayClass will update the observedGeneration in it's conditions when reconciling
31-
SupportGatewayClassObservedGenerationBump SupportedFeature = "GatewayClassObservedGenerationBump"
32-
3351
// This option indicates support for HTTPRoute port redirect (extended conformance).
3452
SupportHTTPRoutePortRedirect SupportedFeature = "HTTPRoutePortRedirect"
3553

@@ -46,12 +64,19 @@ const (
4664
SupportHTTPRoutePathRewrite SupportedFeature = "HTTPRoutePathRewrite"
4765
)
4866

49-
// StandardCoreFeatures are the features that are required to be conformant with
50-
// the Core API features that are part of the Standard release channel.
51-
var StandardCoreFeatures = sets.New(
52-
SupportReferenceGrant,
67+
// -----------------------------------------------------------------------------
68+
// Features - TLS Conformance Profile
69+
// -----------------------------------------------------------------------------
70+
71+
const (
72+
// This option indicates support for TLSRoute (extended conformance).
73+
SupportTLSRoute SupportedFeature = "TLSRoute"
5374
)
5475

76+
// -----------------------------------------------------------------------------
77+
// Features - Compilations
78+
// -----------------------------------------------------------------------------
79+
5580
// AllFeatures contains all the supported features and can be used to run all
5681
// conformance tests with `all-features` flag.
5782
//

0 commit comments

Comments
 (0)