Skip to content

Commit a3432d1

Browse files
shaneuttk8s-ci-robot
authored andcommitted
chore: move RouteDestinationPortMatching to experimental features
1 parent 1c233f6 commit a3432d1

File tree

1 file changed

+20
-4
lines changed

1 file changed

+20
-4
lines changed

conformance/utils/suite/features.go

+20-4
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,6 @@ const (
6060
//
6161
// See: https://github.com/kubernetes-sigs/gateway-api/issues/1780
6262
SupportGatewayClassObservedGenerationBump SupportedFeature = "GatewayClassObservedGenerationBump"
63-
64-
// This option indicates support for Destination Port matching.
65-
SupportRouteDestinationPortMatching SupportedFeature = "RouteDestinationPortMatching"
6663
)
6764

6865
// StandardExtendedFeatures are extra generic features that implementations may
@@ -72,9 +69,27 @@ const (
7269
// See: https://github.com/kubernetes-sigs/gateway-api/issues/1891
7370
var StandardExtendedFeatures = sets.New(
7471
SupportGatewayClassObservedGenerationBump,
75-
SupportRouteDestinationPortMatching,
7672
).Insert(StandardCoreFeatures.UnsortedList()...)
7773

74+
// -----------------------------------------------------------------------------
75+
// Features - Experimental (Extended)
76+
// -----------------------------------------------------------------------------
77+
78+
const (
79+
// This option indicates support for Destination Port matching.
80+
SupportRouteDestinationPortMatching SupportedFeature = "RouteDestinationPortMatching"
81+
)
82+
83+
// ExperimentalExtendedFeatures are extra generic features that are currently
84+
// only available in our experimental release channel, and at an extended
85+
// support level.
86+
//
87+
// TODO: we need clarity for standard vs experimental features.
88+
// See: https://github.com/kubernetes-sigs/gateway-api/issues/1891
89+
var ExperimentalExtendedFeatures = sets.New(
90+
SupportRouteDestinationPortMatching,
91+
)
92+
7893
// -----------------------------------------------------------------------------
7994
// Features - HTTPRoute Conformance (Core)
8095
// -----------------------------------------------------------------------------
@@ -159,5 +174,6 @@ var TLSCoreFeatures = sets.New(
159174
// NOTE: as new feature sets are added they should be inserted into this set.
160175
var AllFeatures = sets.New[SupportedFeature]().
161176
Insert(StandardExtendedFeatures.UnsortedList()...).
177+
Insert(ExperimentalExtendedFeatures.UnsortedList()...).
162178
Insert(HTTPExtendedFeatures.UnsortedList()...).
163179
Insert(TLSCoreFeatures.UnsortedList()...)

0 commit comments

Comments
 (0)