Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update goss serverspec tool to current version #1655

Open
mboersma opened this issue Dec 10, 2024 · 6 comments · May be fixed by #1680
Open

Update goss serverspec tool to current version #1655

mboersma opened this issue Dec 10, 2024 · 6 comments · May be fixed by #1680
Assignees
@sivchari
Labels
area/dependency Issues or PRs related to dependency changes good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@mboersma
Copy link
Contributor

Is your feature request related to a problem? Please describe.

image-builder uses the goss tool to validate image configurations before considering a build successful.

But currently goss is pinned to an old version and sourced from a deprecated URL.

image-builder/images/capi/scripts/ci-goss-populate.sh

Lines 31 to 32 in 5e7ed38

_version="v0.3.16"
_bin_url="https://github.com/aelsabbahy/goss/releases/download/${_version}/goss-linux-amd64"

The old version is also referenced here:

image-builder/images/capi/packer/config/goss-args.json

Line 16 in 5e7ed38

"goss_version": "0.3.16"

and here:

image-builder/docs/book/src/capi/goss/goss.md

Line 41 in 5e7ed38

"goss_version": "0.3.16"

Describe the solution you'd like

The URL and version should be updated to something currently supported and patched.

/kind feature
/area dependency
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/dependency Issues or PRs related to dependency changes labels Dec 10, 2024
@mboersma
Copy link
Contributor Author

/help
/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@mboersma:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/help
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Dec 10, 2024
@mboersma mboersma mentioned this issue Dec 10, 2024
Closed
@jongwooo
Copy link
Member

/assign

@jongwooo jongwooo mentioned this issue Dec 20, 2024
Closed
@mboersma
Copy link
Contributor Author

mboersma commented Feb 3, 2025

@jongwooo if you have time to follow up on #1659, that would be great. If not, could you /unassign this so it's available to others?

@jongwooo
Copy link
Member

jongwooo commented Feb 4, 2025

@mboersma I’m sorry for the late reply.

I'm going to unassign myself as i clearly don't have the bandwidth to tackle the feature.
/unassign

@sivchari
Copy link
Member

sivchari commented Feb 5, 2025

/assign

@sivchari sivchari linked a pull request Feb 5, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sivchari sivchari

Labels
area/dependency Issues or PRs related to dependency changes good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update goss sivchari/image-builder
Bump goss to v0.4.9 jongwooo/image-builder
4 participants
@mboersma @k8s-ci-robot @jongwooo @sivchari