fix: clarify state node logging (#1766)

Author: rschalo

pkg/controllers/disruption/suite_test.go

@@ -1527,7 +1527,7 @@ var _ = Describe("Candidate Filtering", func() {
 		Expect(cluster.Nodes()).To(HaveLen(1))
 		_, err := disruption.NewCandidate(ctx, env.Client, recorder, fakeClock, cluster.Nodes()[0], pdbLimits, nodePoolMap, nodePoolInstanceTypeMap, queue, disruption.GracefulDisruptionClass)
 		Expect(err).To(HaveOccurred())
-		Expect(err.Error()).To(Equal("state node does not have a nodeclaim representation"))
+		Expect(err.Error()).To(Equal("node is not managed by karpenter"))
 	})
 	It("should not consider candidate that has just a NodeClaim representation", func() {
 		nodeClaim, _ := test.NodeClaimAndNode(v1.NodeClaim{
@@ -1546,7 +1546,7 @@ var _ = Describe("Candidate Filtering", func() {
 		Expect(cluster.Nodes()).To(HaveLen(1))
 		_, err := disruption.NewCandidate(ctx, env.Client, recorder, fakeClock, cluster.Nodes()[0], pdbLimits, nodePoolMap, nodePoolInstanceTypeMap, queue, disruption.GracefulDisruptionClass)
 		Expect(err).To(HaveOccurred())
-		Expect(err.Error()).To(Equal("state node does not have a node representation"))
+		Expect(err.Error()).To(Equal("nodeclaim does not have an associated node"))
 	})
 	It("should not consider candidates that are nominated", func() {
 		nodeClaim, node := test.NodeClaimAndNode(v1.NodeClaim{

pkg/controllers/state/statenode.go

@@ -175,10 +175,10 @@ func (in *StateNode) Pods(ctx context.Context, kubeClient client.Client) ([]*cor
 //nolint:gocyclo
 func (in *StateNode) ValidateNodeDisruptable(ctx context.Context, kubeClient client.Client) error {
 	if in.NodeClaim == nil {
-		return fmt.Errorf("state node does not have a nodeclaim representation")
+		return fmt.Errorf("node is not managed by karpenter")
 	}
 	if in.Node == nil {
-		return fmt.Errorf("state node does not have a node representation")
+		return fmt.Errorf("nodeclaim does not have an associated node")
 	}
 	if !in.Initialized() {
 		return fmt.Errorf("state node isn't initialized")