Skip to content

Commit 57012a8

Browse files
Merge pull request #65411 from nikhita/fix-publishing-bot-fakeclient
Automatic merge from submit-queue (batch tested with PRs 63773, 65411). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. client-go/examples/fake-client: add doc.go to fix go build warnings The publishing bot is currently broken (kubernetes/kubernetes#56876 (comment)). This is due to the following error: ``` [24 Jun 18 15:08 UTC]: Running smoke tests for branch master [24 Jun 18 15:08 UTC]: /bin/bash -xec "godep restore\ngo build ./...\ngo test $(go list ./... | grep -v /vendor/)\n" + godep restore + go build ./... go build k8s.io/client-go/examples/fake-client: no non-test Go files in /go-workspace/src/k8s.io/client-go/examples/fake-client [24 Jun 18 15:09 UTC]: exit status 1 + godep restore + go build ./... go build k8s.io/client-go/examples/fake-client: no non-test Go files in /go-workspace/src/k8s.io/client-go/examples/fake-client [24 Jun 18 15:09 UTC]: exit status 1``` ``` The fakeclient package does not have any non-test go files. The test file was added in kubernetes/kubernetes#65291 2 days ago. This causes `go build` to give a warning: `no non-test Go files in /go-workspace/src/k8s.io/client-go/examples/fake-client`, which breaks the publishing bot. This PR adds a dummy doc.go file in the package to avoid this warning and fix the publishing bot. **Release note**: ```release-note NONE ``` Kubernetes-commit: 7a9a30a4f7eae900bffd4b477a431a999de350dd
2 parents 615dfd3 + 933d577 commit 57012a8

File tree

2 files changed

+71
-51
lines changed

2 files changed

+71
-51
lines changed

Godeps/Godeps.json

Lines changed: 51 additions & 51 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

examples/fake-client/doc.go

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
/*
2+
Copyright 2018 The Kubernetes Authors.
3+
4+
Licensed under the Apache License, Version 2.0 (the "License");
5+
you may not use this file except in compliance with the License.
6+
You may obtain a copy of the License at
7+
8+
http://www.apache.org/licenses/LICENSE-2.0
9+
10+
Unless required by applicable law or agreed to in writing, software
11+
distributed under the License is distributed on an "AS IS" BASIS,
12+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
See the License for the specific language governing permissions and
14+
limitations under the License.
15+
*/
16+
17+
// Package fakeclient contains examples on how to use fakeclient in tests.
18+
// Note: This file is here to avoid warnings on go build since there are no
19+
// non-test files in this package.
20+
package fakeclient

0 commit comments

Comments
 (0)