Skip to content

Commit 2438a34

Browse files
committed
cloudbuild.yaml: Drop unnecessary variables
Signed-off-by: Stephen Augustus <[email protected]>
1 parent fe1ab93 commit 2438a34

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

Makefile

-4
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,6 @@ IMG_NAME = publishing-bot
2626

2727
IMG_VERSION ?= v0.0.0-1
2828

29-
BUILD_ARGS = --build-arg=GIT_TAG=$(GIT_TAG) \
30-
--build-arg=IMG_VERSION=$(IMG_VERSION)
31-
3229
# TODO(image): Consider renaming this variable
3330
DOCKER_REPO ?= $(IMG_REGISTRY)/$(IMG_NAME)
3431
NAMESPACE ?=
@@ -60,7 +57,6 @@ build-image: build
6057
-t $(DOCKER_REPO):$(GIT_TAG) \
6158
-t $(DOCKER_REPO):$(IMG_VERSION) \
6259
-t $(DOCKER_REPO):latest \
63-
$(BUILD_ARGS) \
6460
.
6561
.PHONY: build-image
6662

cloudbuild.yaml

+5-5
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ steps:
1313
- name: 'gcr.io/k8s-staging-releng/k8s-ci-builder:latest-default'
1414
entrypoint: make
1515
env:
16-
- GIT_TAG="$_GIT_TAG"
17-
- PULL_BASE_REF="$_PULL_BASE_REF"
18-
- IMG_REGISTRY="gcr.io/$PROJECT_ID"
19-
- IMG_VERSION="$_IMG_VERSION"
16+
- GIT_TAG=$_GIT_TAG
17+
- PULL_BASE_REF=$_PULL_BASE_REF
18+
- IMG_REGISTRY=gcr.io/$PROJECT_ID
19+
- IMG_VERSION=$_IMG_VERSION
2020
args:
2121
- build-and-push-image
2222

@@ -33,7 +33,7 @@ substitutions:
3333
# vYYYYMMDD-hash, and can be used as a substitution
3434
_GIT_TAG: '12345'
3535
_PULL_BASE_REF: 'dev'
36-
_IMG_REGISTRY: 'registry'
36+
_IMG_REGISTRY: 'null-registry'
3737
_IMG_VERSION: 'v0.0.0-1'
3838

3939
tags:

0 commit comments

Comments
 (0)