pkg/gcp/build: Pass build options by pointer (hugeParam)

Signed-off-by: Stephen Augustus <[email protected]>

Author: justaugustus

cmd/gcbuilder/main.go

@@ -90,7 +90,7 @@ func main() {
 		log.Fatalf("Failed to chdir to build directory (%s): %v", o.BuildDir, err)
 	}
 
-	errors := build.RunBuildJobs(o)
+	errors := build.RunBuildJobs(&o)
 	if len(errors) != 0 {
 		log.Fatalf("Failed to run some build jobs: %v", errors)
 	}

pkg/gcp/build/build.go

@@ -111,7 +111,7 @@ func (o *Options) uploadBuildDir(targetBucket string) (string, error) {
 	return uploaded, nil
 }
 
-func getExtraSubs(o Options) map[string]string {
+func getExtraSubs(o *Options) map[string]string {
 	envs := strings.Split(o.EnvPassthrough, ",")
 	subs := map[string]string{}
 	for _, e := range envs {
@@ -123,7 +123,7 @@ func getExtraSubs(o Options) map[string]string {
 	return subs
 }
 
-func runSingleJob(o Options, jobName, uploaded, version string, subs map[string]string) error {
+func runSingleJob(o *Options, jobName, uploaded, version string, subs map[string]string) error {
 	s := make([]string, 0, len(subs)+1)
 	for k, v := range subs {
 		s = append(s, fmt.Sprintf("_%s=%s", k, v))
@@ -189,7 +189,7 @@ func runSingleJob(o Options, jobName, uploaded, version string, subs map[string]
 
 type variants map[string]map[string]string
 
-func getVariants(o Options) (variants, error) {
+func getVariants(o *Options) (variants, error) {
 	content, err := ioutil.ReadFile(path.Join(o.ConfigDir, "variants.yaml"))
 	if err != nil {
 		if !os.IsNotExist(err) {
@@ -216,7 +216,7 @@ func getVariants(o Options) (variants, error) {
 	return v.Variants, nil
 }
 
-func RunBuildJobs(o Options) []error {
+func RunBuildJobs(o *Options) []error {
 	var uploaded string
 	if o.ScratchBucket != "" {
 		if !o.NoSource {