Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: default values for user-defined PostCreateHook variables #233

Open
1 task
MikeSpreitzer opened this issue Apr 10, 2024 · 2 comments
Open
1 task
Labels
enhancement New feature or request priority/low Higher priority than priority/awaiting-more-evidence.

Comments

@MikeSpreitzer
Copy link
Contributor

Feature Description

A PostCreateHook should be able to define default values for its user-defined variables.

Proposed Solution

Add a way to do that.

Want to contribute?

  • I would like to work on this issue.

Additional Context

No response

@pdettori
Copy link
Collaborator

@MikeSpreitzer this sounds like an useful feature, any thoughts on where such default values could be maintained ?

@MikeSpreitzer
Copy link
Contributor Author

The idea that first comes to mind is adding a section in the PostCreateHook object. The simplest schema would be a map from variable name to default value. The recommended pattern in Kubernetes is to eschew such simplicity for the sake of making the domain of every map fixed in the schema, instead using a list of (name, value) pairs.

@pdettori pdettori added enhancement New feature or request priority/low Higher priority than priority/awaiting-more-evidence. labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority/low Higher priority than priority/awaiting-more-evidence.
Projects
Status: No status
Development

No branches or pull requests

2 participants