Resolves: MTV-3561 | Refactor StandardPage (#2105)

* Resolves: MTV-3561 | Refactor StandardPage

Signed-off-by: Jeff Puzzo <[email protected]>

* Resolves: MTV-3561 | Refactor StandardPage - Unit tests

Signed-off-by: Jeff Puzzo <[email protected]>

* Resolves: MTV-3561 | Refactor StandardPage - address feedback

Signed-off-by: Jeff Puzzo <[email protected]>

---------

Signed-off-by: Jeff Puzzo <[email protected]>

Author: jpuzz0

src/components/common/FilterGroup/matchers.ts

@@ -172,12 +172,17 @@ export const createMetaMatcher =
     resourceFields: ResourceField[],
     valueMatchers: ValueMatcher<string>[] = defaultValueMatchers,
   ) =>
-  (
-    resourceData: Record<string, object | string | boolean | ((resourceData: unknown) => unknown)>,
-  ): boolean =>
+  (resourceData: unknown): boolean =>
     valueMatchers
       .map(({ filterType, matchValue }) =>
         createMatcher({ filterType, matchValue, resourceFields, selectedFilters }),
       )
-      .map((match) => match(resourceData))
+      .map((match) =>
+        match(
+          resourceData as Record<
+            string,
+            object | string | boolean | ((resourceData: unknown) => unknown)
+          >,
+        ),
+      )
       .every(Boolean);

src/components/page/StandardPage.style.css

@@ -1,7 +1,3 @@
-.forklift-page__main-title {
-  padding-bottom: 0;
-}
-
 .forklift-page__toolbar-item__selected-count {
   color: var(--pf-t--global--text--color--subtle);
   margin-inline-start: auto;