Resolves: MTV-3743 | Standardize editing settings

Signed-off-by: Aviv Turgeman <[email protected]>

Author: avivtur

locales/en/plugin__forklift-console-plugin.json

@@ -133,7 +133,6 @@
   "Affinity rules": "Affinity rules",
   "Affinity rules allows you to specify hard-and soft-affinity for virtual machines. It is possible to write matching rules against workloads (virtual machines and Pods) and Nodes.": "Affinity rules allows you to specify hard-and soft-affinity for virtual machines. It is possible to write matching rules against workloads (virtual machines and Pods) and Nodes.",
   "All": "All",
-  "All changes saved": "All changes saved",
   "All networks detected on the selected VMs require a mapping.": "All networks detected on the selected VMs require a mapping.",
   "All past migration runs for this plan. This includes both successful and failed attempts, but detailed logs and other data are not available after the migration pods are deleted. If you retry an incomplete migration, only the failed VMs will migrate again.": "All past migration runs for this plan. This includes both successful and failed attempts, but detailed logs and other data are not available after the migration pods are deleted. If you retry an incomplete migration, only the failed VMs will migrate again.",
   "All storages detected on the selected VMs require a mapping.": "All storages detected on the selected VMs require a mapping.",
@@ -330,6 +329,7 @@
   "Edit provider web UI link": "Edit provider web UI link",
   "Edit PVC name template": "Edit PVC name template",
   "Edit root device": "Edit root device",
+  "Edit Settings": "Edit Settings",
   "Edit step": "Edit step",
   "Edit storage map": "Edit storage map",
   "Edit target name": "Edit target name",

src/components/headers/SectionHeading.tsx

@@ -2,7 +2,7 @@ import type { FC, ReactNode } from 'react';
 
 import { Title, type TitleProps } from '@patternfly/react-core';
 
-type SectionHeadingProps = {
+export type SectionHeadingProps = {
   text: ReactNode;
   className?: string;
   id?: string;

src/components/headers/SectionHeadingWithEdit.tsx

@@ -0,0 +1,45 @@
+import type { FC } from 'react';
+
+import { Button, ButtonVariant, Flex } from '@patternfly/react-core';
+import { PencilAltIcon } from '@patternfly/react-icons';
+import { useForkliftTranslation } from '@utils/i18n';
+
+import SectionHeading, { type SectionHeadingProps } from './SectionHeading';
+
+type SectionHeadingWithEditProps = Omit<
+  {
+    title: string;
+    editable: boolean;
+    onClick: () => void;
+  } & SectionHeadingProps,
+  'text'
+>;
+
+const SectionHeadingWithEdit: FC<SectionHeadingWithEditProps> = ({
+  editable,
+  onClick,
+  title,
+  ...rest
+}) => {
+  const { t } = useForkliftTranslation();
+  return (
+    <SectionHeading
+      {...rest}
+      text={
+        <Flex direction={{ default: 'row' }} gap={{ default: 'gapSm' }}>
+          {title}
+          <Button
+            icon={<PencilAltIcon />}
+            variant={ButtonVariant.link}
+            onClick={onClick}
+            isDisabled={!editable}
+          >
+            {t('Edit')}
+          </Button>
+        </Flex>
+      }
+    />
+  );
+};
+
+export default SectionHeadingWithEdit;

src/modules/Providers/modals/EditModal/utils/defaultOnConfirm.ts

@@ -1,6 +1,6 @@
 import {
   getValueByJsonPath,
-  jsonPathToPatch,
+  openApiJsonPathToPatch,
 } from 'src/modules/Providers/utils/helpers/getValueByJsonPath';
 
 import type { OpenApiJsonPath } from '@components/common/utils/types';
@@ -25,39 +25,18 @@ export const defaultOnConfirm = async ({
   jsonPath: OpenApiJsonPath;
   model: K8sModel;
 }) => {
-  const path = getValueByJsonPath(resource, jsonPath);
-  const op = path ? REPLACE : ADD;
+  const value = getValueByJsonPath(resource, jsonPath);
+  const op = value ? REPLACE : ADD;
 
   return k8sPatch<K8sResourceCommon>({
     data: [
       {
         op,
-        path: jsonPathToPatch(path),
+        path: openApiJsonPathToPatch(resource, jsonPath),
         value: newValue,
       },
     ],
     model,
     resource,
   });
 };
-
-/**
- * Wraps the defaultOnConfirm method to convert the newValue from string to int before patching.
- */
-export const defaultOnConfirmWithIntValue = async ({
-  jsonPath,
-  model,
-  newValue,
-  resource,
-}: {
-  resource: K8sResourceCommon;
-  newValue: unknown;
-  jsonPath: OpenApiJsonPath;
-  model: K8sModel;
-}) => {
-  // Convert the newValue from string to int
-  const intValue = parseInt(String(newValue), 10);
-
-  // Call the original method with the converted value
-  return defaultOnConfirm({ jsonPath, model, newValue: intValue, resource });
-};

src/modules/Providers/utils/helpers/getValueByJsonPath.ts

@@ -18,8 +18,19 @@ export const getValueByJsonPath = (obj: unknown, pathOrFunction: OpenApiJsonPath
   return pathParts.reduce((path: any, key: string) => path?.[key], obj) as string;
 };
 
-export const jsonPathToPatch = (path: string | string[]) => {
-  let pathParts = typeof path === 'string' ? path.split('.') : path;
+/**
+ * Converts a JSON path in dot notation to a JSON Patch path.
+ *
+ * @param obj - The object (not used in this function but kept for consistency with getValueByJsonPath).
+ * @param pathOrFunction - The JSON path (dot notation) or a function that returns the desired path.
+ * @returns The JSON Patch path as a string.
+ */
+export const openApiJsonPathToPatch = (obj: unknown, pathOrFunction: OpenApiJsonPath) => {
+  if (typeof pathOrFunction === 'function') {
+    return pathOrFunction(obj);
+  }
+
+  let pathParts = typeof pathOrFunction === 'string' ? pathOrFunction.split('.') : pathOrFunction;
 
   pathParts = pathParts.map((pathPart) => pathPart.replaceAll('/', '~1'));
 

src/overview/tabs/Settings/ForkliftControllerSettingsTab.tsx

@@ -4,7 +4,7 @@ import { useK8sWatchForkliftController } from 'src/overview/hooks/useK8sWatchFor
 
 import { Bullseye } from '@patternfly/react-core';
 
-import SettingsCard from './cards/SettingsCard';
+import SettingsCard from './components/SettingsCard';
 
 const ForkliftControllerSettingsTab: FC = () => {
   const [forkliftController, controllerLoaded, controllerLoadError] =