From fe718c081567a274448858c7b24fe1a88ea8ca25 Mon Sep 17 00:00:00 2001 From: Jeff Puzzo Date: Thu, 30 Jan 2025 10:03:06 -0500 Subject: [PATCH] remove import from index for loading spinner component Signed-off-by: Jeff Puzzo --- packages/common/src/components/LoadingSpinner.tsx | 2 +- packages/common/src/components/index.ts | 1 - .../views/list/components/PlanStatusCell/PlanStatusCell.tsx | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/common/src/components/LoadingSpinner.tsx b/packages/common/src/components/LoadingSpinner.tsx index 148469e3a..d04cbff03 100644 --- a/packages/common/src/components/LoadingSpinner.tsx +++ b/packages/common/src/components/LoadingSpinner.tsx @@ -8,6 +8,6 @@ type LoadingSpinnerProps = PropsWithChildren & }; const LoadingSpinner: FC = ({ isLoading, children, ...spinnerProps }) => - isLoading ? : children; + isLoading ? : <>{children}; export default LoadingSpinner; diff --git a/packages/common/src/components/index.ts b/packages/common/src/components/index.ts index 5e0351c52..28db5f4a5 100644 --- a/packages/common/src/components/index.ts +++ b/packages/common/src/components/index.ts @@ -6,7 +6,6 @@ export * from './FormGroupWithHelpText'; export * from './HelpIconPopover'; export * from './Icons'; export * from './LoadingDots'; -export { default as LoadingSpinner } from './LoadingSpinner'; export * from './Page'; export * from './QueryClientHoc'; export * from './TableView'; diff --git a/packages/forklift-console-plugin/src/modules/Plans/views/list/components/PlanStatusCell/PlanStatusCell.tsx b/packages/forklift-console-plugin/src/modules/Plans/views/list/components/PlanStatusCell/PlanStatusCell.tsx index 772dd5f66..768b6efd7 100644 --- a/packages/forklift-console-plugin/src/modules/Plans/views/list/components/PlanStatusCell/PlanStatusCell.tsx +++ b/packages/forklift-console-plugin/src/modules/Plans/views/list/components/PlanStatusCell/PlanStatusCell.tsx @@ -12,7 +12,7 @@ import { useModal } from 'src/modules/Providers/modals'; import { getResourceUrl } from 'src/modules/Providers/utils'; import { useForkliftTranslation } from 'src/utils/i18n'; -import { LoadingSpinner } from '@kubev2v/common'; +import LoadingSpinner from '@kubev2v/common/src/components/LoadingSpinner'; import { PlanModel, PlanModelRef } from '@kubev2v/types'; import { Button, Flex, FlexItem, spinnerSize, Split, SplitItem } from '@patternfly/react-core'; import StartIcon from '@patternfly/react-icons/dist/esm/icons/play-icon';