Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Bugs and Admin Toggle Feature #68

Open
harshit-soora opened this issue May 27, 2021 · 3 comments
Open

Minor Bugs and Admin Toggle Feature #68

harshit-soora opened this issue May 27, 2021 · 3 comments

Comments

@harshit-soora
Copy link

These are the functions that I have added:

  1. A admin toggle on register page for admin , (alternative - this feature could be in-build inside the code with some super user too whose credential are already stored when the system runs.)
  2. Students list feature in admin which allow the admin to get details of students who have registered

These are the issues that I have resolve:

  1. Admin login doesn't redirect to admin dashboard instead it redirect to normal dashboard
  2. Add Book and Remove book have some query error in it which have been resolved.
  3. After issue book the list show author and book name as empty (added a join query to resolve that)
  4. Remove book have similar error where the drop down list doesn't have Book and Author name

There were some minor errors/bug in between, I will be adding my work under this issue. You can review and merge it.

One more courtesy, I will be adding the newer version at my Github repo for sure I will promote your work :)

Your coding style was very nice :D

@kumaraditya303 kumaraditya303 changed the title There are many broken elements in this repo, after this merge all will be set !! Minor Bugs and Admin Toggle Feature May 28, 2021
@kumaraditya303
Copy link
Owner

Hi @harshit-soora,

A admin toggle on register page for admin , (alternative - this feature could be in-build inside the code with some super user too whose credential are already stored when the system runs.)

This should be implemented at the backend itself for security issues, this could be implemented with a cli which directly write to the db and creates super user.

Students list feature in admin which allow the admin to get details of students who have registered

Nice feature!

Your coding style was very nice :D
Thanks

@harshit-soora
Copy link
Author

Yes @kumaraditya303 for future releases you can just hard code one entry of admin directly inside the view.py file.

For my use-case, I had to explicitly show how a admin is registered that's why I kept it that why

In future that toggle could be for anything like "more privileged user like research scholar or something"

@Josh2077
Copy link

$ git clone https://github.com/kumaraditya303/Library-Managament-System.git
Cloning into 'Library-Managament-System'...
remote: Repository not found.
fatal: repository 'https://github.com/kumaraditya303/Library-Managament-System.g
it/' not found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants