Convert uk.gov.dstl.geo.osgb package from Java to Kotlin #143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the
uk.gov.dstl.geo.osgbpackage from Java to Kotlin, modernizing the codebase while maintaining full backward compatibility.Changes
Converted Files
All 5 Java classes in the package have been converted to Kotlin:
objectwithconst valdeclarationsobject, using Kotlin's native math functionsobjectwith simplified syntaxobjectwith nativePIconstant usageobjectwith nullable return types (String?instead ofOptional<String>)Key Improvements
String?) instead of Java'sOptionalobjectsingletonspow(),sin(),cos(), etc. instead ofMath.*Compatibility
CoordinateFormatter.ktupdated to use Kotlin nullable types fortoNationalGrid()The conversion maintains the original Apache 2.0 license headers and all functionality from the Dstl OSGB library.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
api.tidesandcurrents.noaa.gov/usr/lib/jvm/temurin-11-jdk-amd64/bin/java -Dorg.gradle.internal.worker.tmpdir=/home/REDACTED/work/sol/sol/build/tmp/test/work @/home/REDACTED/.gradle/.tmp/gradle-worker-classpath1874939413018271539txt -Xmx512m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -ea worker.org.gradle.process.internal.worker.GradleWorkerMain 'Gradle Test Executor 3'(dns block)/usr/lib/jvm/temurin-11-jdk-amd64/bin/java -Dorg.gradle.internal.worker.tmpdir=/home/REDACTED/work/sol/sol/build/tmp/test/work @/home/REDACTED/.gradle/.tmp/gradle-worker-classpath16948213823978763471txt -Xmx512m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -ea worker.org.gradle.process.internal.worker.GradleWorkerMain 'Gradle Test Executor 5'(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
Fixes #141
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.