Skip to content

Custom instrumentations scopes are overwritten for prometheus inputs #2638

@a-thaler

Description

@a-thaler

Description

When exposing metrics in a workload using the otel-sdk and the prometheus exporter, an istrumentation scope can be configured and the prometheusreceiver in the otel-collector will enrich it properly. However, the config of the metric agent will overwrite the custom scope with our fixed scope.

Goal: Preserve any custom instrumentation scope provided by an input (prometheis, otlp) and set the kyma scope only if no value is defined
As the scope was used for routing and filtering decision as a marker from which input data was coming in, instead a new attribute kyma.input.name should be enriched always which gets removed later on in the flow.

Criterias:

  • For metric agent mainly, potentially also gateways for OTLP input
  • Never override a custom instrumentation scope, always try to enrich if missing/possible
  • Routing and filtering is not based on the instrumentation scope as this is not identifying the input anymore reliable

Metadata

Metadata

Assignees

Labels

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions