Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support partially-signed trasnactions #92

Open
sohrab- opened this issue Oct 24, 2022 · 4 comments
Open

Support partially-signed trasnactions #92

sohrab- opened this issue Oct 24, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@sohrab-
Copy link
Member

sohrab- commented Oct 24, 2022

  • Save/export partially-signed transactions
  • Load and sign existing partially-signed transactions

For this to work, should be able to:

  • Import a partially-signed transaction buffer
  • Include existing signatures during the transaction send
  • Export data model to store signatures
    • Need to make sure our mappings are precise, otherwise the signature becomes invalid
@sohrab- sohrab- added the enhancement New feature or request label Oct 24, 2022
@yamen
Copy link
Member

yamen commented Oct 24, 2022

This also makes the transaction read only... if it's changed the signature is no longer valid

@yamen
Copy link
Member

yamen commented Oct 24, 2022

An implication of that is that you don't need to accurately regenerate the serialised version - it must already exist

@josephlabeleven
Copy link
Contributor

just thinking the partial-signed transaction will expire in 150 blocks (approximately 1 min after it is generated), should there be something to indicate the user the expiry time of the transaction? This is so the user is not surprised when transaction expires if they read the instructions too long.

@yamen
Copy link
Member

yamen commented Oct 25, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants