Skip to content

Commit e6f24aa

Browse files
committed
Addressed PR feedback
1 parent 26ab188 commit e6f24aa

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

middleware/cors.go

+9-9
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,15 @@ func CORSWithConfig(config CORSConfig) echo.MiddlewareFunc {
120120
return c.NoContent(http.StatusNoContent)
121121
}
122122

123-
if config.AllowOriginFunc == nil {
123+
if config.AllowOriginFunc != nil {
124+
allowed, err := config.AllowOriginFunc(origin)
125+
if err != nil {
126+
return err
127+
}
128+
if allowed {
129+
allowOrigin = origin
130+
}
131+
} else {
124132
// Check allowed origins
125133
for _, o := range config.AllowOrigins {
126134
if o == "*" && config.AllowCredentials {
@@ -156,14 +164,6 @@ func CORSWithConfig(config CORSConfig) echo.MiddlewareFunc {
156164
}
157165
}
158166
}
159-
} else {
160-
allowed, err := config.AllowOriginFunc(origin)
161-
if err != nil {
162-
return err
163-
}
164-
if allowed {
165-
allowOrigin = origin
166-
}
167167
}
168168

169169
// Origin not allowed

0 commit comments

Comments
 (0)