-
Notifications
You must be signed in to change notification settings - Fork 7
Labwc icon to ship within the main repo for its labwc.desktop session file #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I believe that if you use a SVG it doesn't matter the image size, maybe just the proportion for the margins when scaled? Not sure. |
Good stuff redtide -- I could not resist the temptation and edit it a bit w/ a text editor:
|
Thank you! But now it misses a "Simplified and optimized by domo141" :) |
For comparison: labwc2.svg from this repo (svg 1.2 KiB): l2.svg created by @domo141 (svg 584 Bytes) labwc_redtide_1 from post above (svg, 558 Bytes) I think the main issue is that |
This is a complete nit-pick (OCD methinks) but I dislike mixing absolute and relative svg paths. <svg xmlns="http://www.w3.org/2000/svg" width="256px" height="256px"
viewBox="0 0 114 114"
stroke-linecap="round" stroke-linejoin="round" stroke-width="6">
<path fill="#f0d70f" stroke="#f0d70f" d="m 6 18 46 27 v 55 l -39 -30 z"/>
<path fill="#d02f90" stroke="#d02f90" d="m 108 18 -47 27 v 55 l 39 -30 z"/>
</svg> |
01micko: I like that -- tried but failed with that L -> l change (due not understood to change that -39 -30 at the end :D |
With relpaths it's a simple matter to drop the whole image 10 units (in my case |
yes simple expnanation of the first path above: (m 6,18 46,27 v 55 l -39,-30)
(and the second, purple path, circles counterclockwise) (for symmetry probably that 46 and -47 should have same abs value) |
For some reason I thought it was a colored book, not a cube 😶🌫️ |
Maybe its both :) |
More funplay: viewbox="0 0 256 256" (and coordinates scaled to that), for easier "understanding"
|
Logo by @domo141 posted at labwc/labwc.github.io#42 (comment): SVG: <?xml version="1.0" encoding="UTF-8"?>
<!--labwc logo #2 (C) Johan Malm LICENSE: CC BY-SA 4.0-->
<svg xmlns="http://www.w3.org/2000/svg" width="256px" height="256px"
viewbox="0 0 256 256"
stroke-linecap="round" stroke-linejoin="round" stroke-width="12">
<path fill="#f0d70f" stroke="#f0d70f" d="m 26 68 91 55 v 108 l -76 -61 z" />
<path fill="#d02f90" stroke="#d02f90" d="m 229 68 -91 55 v 108 l 76 -61 z" />
</svg> Personally I think it looks pretty great. Thanks to everybody contributing here! |
...and as an original author |
@domo141 you're the original author of the cube logo? |
No, not me, @johanmalm - sorry for the confusion... |
I like this one by @domo141 and it seems incredible close to the original one (https://github.com/labwc/labwc-artwork/blob/main/logos/labwc2.svg) but has much simpler XML code which is nice. I suggest putting it at Does anyone feel like doing the honours of a PR? If not, I can sort next week. As next steps I think we should:
|
A .desktop file was previously added for the labwc session, this adds a badge for it where it is supported. The .desktop files and the badges are also moved to `data/`. Ref: #36, 9fa783e, labwc/labwc-artwork#7
I've adjusted the PR at labwc/labwc#1462 so it should be ready to review now. (I just saw it was merged.)
I can create a PR for this and link it to the aforementioned PR too. I had a question of if the |
Great. Regarding the |
We could also rename the variants from the main repo to |
No qualms here. :) |
I think this is closed by #9 . Feel free to re-open if necessary. Also in 758ae11 I updated the logo in the |
A .desktop file was previously added for the labwc session, this adds a badge for it where it is supported. The .desktop files and the badges are also moved to `data/`. Ref: labwc#36, 9fa783e, labwc/labwc-artwork#7
Ref:
Lets brainstorm here regarding the proper dimensions / scaling / transparency.
What we need is a squared canvas with a properly sized labwc logo, I think the default is 256x256 but not sure about that.
The text was updated successfully, but these errors were encountered: