Skip to content

Labwc icon to ship within the main repo for its labwc.desktop session file #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Consolatis opened this issue Jan 23, 2024 · 21 comments

Comments

@Consolatis
Copy link
Member

Consolatis commented Jan 23, 2024

Ref:

Lets brainstorm here regarding the proper dimensions / scaling / transparency.
What we need is a squared canvas with a properly sized labwc logo, I think the default is 256x256 but not sure about that.

@redtide
Copy link

redtide commented Jan 23, 2024

I believe that if you use a SVG it doesn't matter the image size, maybe just the proportion for the margins when scaled? Not sure.
I did some work last night with Inkscape and SVGOMG today to reduce it a bit (left some detail in the image comments). If you are going to use it, feel free to modify it as required.

@domo141
Copy link

domo141 commented Jan 23, 2024

Good stuff redtide -- I could not resist the temptation and edit it a bit w/ a text editor:

<!--Modified by redtide with Inkscape (http://www.inkscape.org/) and SVGOMG (https://jakearchibald.github.io/svgomg/)-->
<!--labwc logo squared (C) Johan Malm LICENSE: CC BY-SA 4.0-->
<svg xmlns="http://www.w3.org/2000/svg" width="256mm" height="256mm"
     viewBox="0 0 114 114"
     stroke-linecap="round" stroke-linejoin="round" stroke-width="6">
  <path fill="#f0d70f" stroke="#f0d70f" d="m 6 18 46 27 v 55 L 13 69 Z"/>
  <path fill="#d02f90" stroke="#d02f90" d="m 108 18 -47 27 v 55 l 39 -30 z"/>
</svg>

@redtide
Copy link

redtide commented Jan 23, 2024

Good stuff redtide -- I could not resist the temptation and edit it a bit w/ a text editor:

<!--Modified by redtide with Inkscape (http://www.inkscape.org/) and SVGOMG (https://jakearchibald.github.io/svgomg/)-->
<!--labwc logo squared (C) Johan Malm LICENSE: CC BY-SA 4.0-->
<svg xmlns="http://www.w3.org/2000/svg" width="256mm" height="256mm"
     viewBox="0 0 114 114"
     stroke-linecap="round" stroke-linejoin="round" stroke-width="6">
  <path fill="#f0d70f" stroke="#f0d70f" d="m 6 18 46 27 v 55 L 13 69 Z"/>
  <path fill="#d02f90" stroke="#d02f90" d="m 108 18 -47 27 v 55 l 39 -30 z"/>
</svg>

Thank you! But now it misses a "Simplified and optimized by domo141" :)

@Consolatis
Copy link
Member Author

For comparison:
Orga logo (png 5.2 KiB):
labwc_orga_logo

labwc2.svg from this repo (svg 1.2 KiB):
labwc2

l2.svg created by @domo141 (svg 584 Bytes)
l2

labwc_redtide_1 from post above (svg, 558 Bytes)
labwc_redtide_1

I think the main issue is that labwc_redtide_1 centers the logo compared to the orga logo that offsets it a bit to the bottom which makes sense as the implied invisible top pane of the cube is also part of the logo. Otherwise I think that one would be pretty perfect.

@01micko
Copy link

01micko commented Jan 23, 2024

This is a complete nit-pick (OCD methinks) but I dislike mixing absolute and relative svg paths.

<svg xmlns="http://www.w3.org/2000/svg" width="256px" height="256px"
     viewBox="0 0 114 114"
     stroke-linecap="round" stroke-linejoin="round" stroke-width="6">
  <path fill="#f0d70f" stroke="#f0d70f" d="m 6 18 46 27 v 55 l -39 -30 z"/>
  <path fill="#d02f90" stroke="#d02f90" d="m 108 18 -47 27 v 55 l 39 -30 z"/>
</svg>

@domo141
Copy link

domo141 commented Jan 23, 2024

01micko: I like that -- tried but failed with that L -> l change (due not understood to change that -39 -30 at the end :D

@01micko
Copy link

01micko commented Jan 23, 2024

centers the logo

With relpaths it's a simple matter to drop the whole image 10 units (in my case px)

@domo141
Copy link

domo141 commented Jan 23, 2024

yes

simple expnanation of the first path above: (m 6,18 46,27 v 55 l -39,-30)

  • move to coordinates 6.18
  • implicit lineto to 46,27 (46 right, 27 down)
  • vertical lineto 55 down
  • lineto 39 left, 30 up
  • z closepath's

(and the second, purple path, circles counterclockwise)

(for symmetry probably that 46 and -47 should have same abs value)

@redtide
Copy link

redtide commented Jan 23, 2024

For some reason I thought it was a colored book, not a cube 😶‍🌫️

@Consolatis
Copy link
Member Author

Maybe its both :)

@domo141
Copy link

domo141 commented Jan 23, 2024

More funplay: viewbox="0 0 256 256" (and coordinates scaled to that), for easier "understanding"

<?xml version="1.0" encoding="UTF-8"?>
<!--labwc logo #2 (C) Johan Malm LICENSE: CC BY-SA 4.0-->
<svg xmlns="http://www.w3.org/2000/svg" width="256px" height="256px"
     viewbox="0 0 256 256"
     stroke-linecap="round" stroke-linejoin="round" stroke-width="14">
  <path fill="#f0d70f" stroke="#f0d70f" d="m 11 41 105 61 v 123 l -87 -68 z" />
  <path fill="#d02f90" stroke="#d02f90" d="m 244 41 -105 61 v 123 l 87 -68 z" />
</svg>

@Consolatis
Copy link
Member Author

Consolatis commented Feb 3, 2024

Logo by @domo141 posted at labwc/labwc.github.io#42 (comment):
labwc_logo_domo

SVG:

<?xml version="1.0" encoding="UTF-8"?>
<!--labwc logo #2 (C) Johan Malm LICENSE: CC BY-SA 4.0-->
<svg xmlns="http://www.w3.org/2000/svg" width="256px" height="256px"
     viewbox="0 0 256 256"
     stroke-linecap="round" stroke-linejoin="round" stroke-width="12">
  <path fill="#f0d70f" stroke="#f0d70f" d="m 26 68 91 55 v 108 l -76 -61 z" />
  <path fill="#d02f90" stroke="#d02f90" d="m 229 68 -91 55 v 108 l 76 -61 z" />
</svg>

Personally I think it looks pretty great. Thanks to everybody contributing here!
Up to @johanmalm as the project lead to decide on the actual logo to use as icon.

@domo141
Copy link

domo141 commented Feb 3, 2024

...and as an original author

@ludg1e
Copy link

ludg1e commented Feb 3, 2024

@domo141 you're the original author of the cube logo?

@domo141
Copy link

domo141 commented Feb 3, 2024

No, not me, @johanmalm - sorry for the confusion...

@johanmalm
Copy link
Contributor

SVG:

<?xml version="1.0" encoding="UTF-8"?>
<!--labwc logo #2 (C) Johan Malm LICENSE: CC BY-SA 4.0-->
<svg xmlns="http://www.w3.org/2000/svg" width="256px" height="256px"
     viewbox="0 0 256 256"
     stroke-linecap="round" stroke-linejoin="round" stroke-width="12">
  <path fill="#f0d70f" stroke="#f0d70f" d="m 26 68 91 55 v 108 l -76 -61 z" />
  <path fill="#d02f90" stroke="#d02f90" d="m 229 68 -91 55 v 108 l 76 -61 z" />
</svg>

Personally I think it looks pretty great. Thanks to everybody contributing here! Up to @johanmalm as the project lead to decide on the actual logo to use as icon.

I like this one by @domo141 and it seems incredible close to the original one (https://github.com/labwc/labwc-artwork/blob/main/logos/labwc2.svg) but has much simpler XML code which is nice.

I suggest putting it at data/labwc.svg

Does anyone feel like doing the honours of a PR? If not, I can sort next week.

As next steps I think we should:

  1. Create a new labwc2-with-text.svg based on the above. Let's settle the font discussion first though.
  2. Move docs/labwc.desktop to data/ too.
  3. Add a data/labwc-symbolic.svg
  4. Adjust meson.build
  5. Remove the equivalent files from logos/

johanmalm pushed a commit to labwc/labwc that referenced this issue Feb 3, 2024
A .desktop file was previously added for the labwc session, this adds a
badge for it where it is supported. The .desktop files and the badges
are also moved to `data/`.

Ref: #36, 9fa783e, labwc/labwc-artwork#7
@rcalixte
Copy link
Contributor

rcalixte commented Feb 3, 2024

I suggest putting it at data/labwc.svg

Does anyone feel like doing the honours of a PR? If not, I can sort next week.

As next steps I think we should:

2. Move `docs/labwc.desktop` to `data/` too.

3. Add a `data/labwc-symbolic.svg`

4. Adjust `meson.build`

I've adjusted the PR at labwc/labwc#1462 so it should be ready to review now. (I just saw it was merged.)

5. Remove the equivalent files from `logos/`

I can create a PR for this and link it to the aforementioned PR too. I had a question of if the labwc.svg in the root should be removed as well @johanmalm.

@johanmalm
Copy link
Contributor

5. Remove the equivalent files from `logos/`

I can create a PR for this and link it to the aforementioned PR too. I had a question of if the labwc.svg in the root should be removed as well @johanmalm.

Great.

Regarding the labwc.svg in the root directory, yes, I think that should be removed now, but we ought to check with @01micko because they created that one.

@johanmalm johanmalm reopened this Feb 3, 2024
@Consolatis
Copy link
Member Author

We could also rename the variants from the main repo to labwc_icon.svg / labwc_icon-symbolic.svg in this repo. We don't really need to have a single combined file for all use-cases (e.g. https://labwc.github.io, screenshots, icon and so on).

@01micko
Copy link

01micko commented Feb 3, 2024

No qualms here. :)

@01micko
Copy link

01micko commented Mar 16, 2024

I think this is closed by #9 . Feel free to re-open if necessary.

Also in 758ae11 I updated the logo in the labwcmoon.ttf font. A little demo follows.. (made with mkwallpaper )

labwc-wall6

@01micko 01micko closed this as completed Mar 16, 2024
grisha128 pushed a commit to grisha128/labwc that referenced this issue Apr 19, 2024
A .desktop file was previously added for the labwc session, this adds a
badge for it where it is supported. The .desktop files and the badges
are also moved to `data/`.

Ref: labwc#36, 9fa783e, labwc/labwc-artwork#7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants