Listen for FormData error events

 - Add ENOENT case to tests

Author: scriptype

lib/node/index.js

@@ -177,7 +177,13 @@ for (var key in requestBase) {
  */
 
 Request.prototype.attach = function(field, file, filename){
-  if (!this._formData) this._formData = new FormData();
+  if (!this._formData) {
+    this._formData = new FormData();
+    this._formData.on('error', function(err) {
+      this.emit('error', err);
+      this.abort();
+    }.bind(this));
+  }
   if ('string' == typeof file) {
     if (!filename) filename = file;
     debug('creating `fs.ReadStream` instance for file: %s', file);

lib/node/part.js

@@ -125,7 +125,13 @@ Part.prototype._attach = function(){
   if (!this._name) throw new Error('must call `Part#name()` first!');
 
   // add `this` Stream's readable side as a stream for this Part
-  if (!this._req._formData) this._req._formData = new FormData();
+  if (!this._req._formData) {
+    this._req._formData = new FormData();
+    this._req._formData.on('error', function(err) {
+      this._req.emit('error', err);
+      this._req.abort();
+    }.bind(this));
+  }
   this._req._formData.append(this._name, this, {
     contentType: this._type,
     filename: this._filename

lib/request-base.js

@@ -164,6 +164,10 @@ exports.field = function(name, val) {
   if (!this._formData) {
     var FormData = require('form-data'); // browserify compatible. May throw if FormData is not supported natively.
     this._formData = new FormData();
+    this._formData.on('error', function(err) {
+      this.emit('error', err);
+      this.abort();
+    }.bind(this));
   }
   this._formData.append(name, val);
   return this;

test/node/multipart.js

@@ -177,6 +177,21 @@ describe('Request', function(){
         done();
       })
     })
+    it('filesystem errors should be caught', function(done){
+      var timestamp = Date.now()
+      request
+          .post(base + '/echo')
+          .attach('filedata', 'test/node/fixtures/lorem-' + timestamp + '.ext')
+          .on('error', function(err) {
+            err.code.should.equal('ENOENT')
+            err.path.should.equal('test/node/fixtures/lorem-' + timestamp + '.ext')
+            done()
+          })
+          .end(function (err, res) {
+            console.log('END')
+            done(new Error("Request should have been aborted earlier!"))
+          })
+    })
   })
 })