clippy

Author: laffed

src/array/three_sum.rs

@@ -44,17 +44,21 @@ fn two_sum_ii(nums: &Vec<i32>, i: usize, res: &mut Vec<Vec<i32>>) {
 
     while lo < hi {
         let sum = nums[i] + nums[lo] + nums[hi];
-        if sum < 0 {
-            lo += 1;
-        } else if sum > 0 {
-            hi -= 1;
-        } else {
-            res.push(vec![nums[i], nums[lo], nums[hi]]);
-            lo += 1;
-            hi -= 1;
-            while lo < hi && nums[lo] == nums[lo - 1] {
+        match sum.cmp(&0) {
+            std::cmp::Ordering::Less => {
                 lo += 1;
             }
+            std::cmp::Ordering::Greater => {
+                hi -= 1;
+            }
+            std::cmp::Ordering::Equal => {
+                res.push(vec![nums[i], nums[lo], nums[hi]]);
+                lo += 1;
+                hi -= 1;
+                while lo < hi && nums[lo] == nums[lo - 1] {
+                    lo += 1;
+                }
+            }
         }
     }
 }

src/array/two_sum.rs

@@ -53,7 +53,7 @@ where
     for (j, x) in nums.into_iter().enumerate() {
         let diff = target - x;
         if let Some(i) = dict.get(&diff) {
-            return (i.clone() as i32, j as i32);
+            return (*i as i32, j as i32);
         }
 
         dict.insert(x, j);

src/dp/coin_change.rs

@@ -37,7 +37,7 @@ fn dfs(coins: &Vec<u32>, rem: Option<u32>) -> Option<u32> {
     let mut min_cost = u32::MAX;
     for coin in coins.iter() {
         let next_rem = rem.checked_sub(*coin);
-        let res = dfs(&coins, next_rem);
+        let res = dfs(coins, next_rem);
         if let Some(r) = res {
             min_cost = min_cost.min(r + 1);
         }

src/dp/maximum_subarray.rs

@@ -23,10 +23,10 @@ pub fn solution_a(nums: Vec<i32>) -> i32 {
     let mut curr_sub = i32::MIN;
 
     for n in nums.iter() {
-        let curr_sub_plus_n = curr_sub.saturating_add(n.clone());
+        let curr_sub_plus_n = curr_sub.saturating_add(*n);
         // if curr_sub is negative, curr_sub_plus_n will always be < n
         // therefore max of n and curr_sub_plus_n is equivalent to "reset curr_sub if negative"
-        curr_sub = n.clone().max(curr_sub_plus_n);
+        curr_sub = (*n).max(curr_sub_plus_n);
         max_sub = max_sub.max(curr_sub);
     }
 

src/util.rs

@@ -5,6 +5,7 @@ pub struct TestCase<I, E> {
 }
 
 #[cfg(test)]
+#[allow(dead_code)]
 impl<I, E> TestCase<I, E> {
     pub fn new(input: I, expected: E) -> Self {
         TestCase { input, expected }