Skip to content

Commit ee8fe26

Browse files
Merge branch 'main' into dori/is-accessed
2 parents 8e8af44 + 7c4ecdf commit ee8fe26

9 files changed

+27
-21
lines changed

Diff for: .github/workflows/bench.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: benchmark
22

33
on:
44
push:
5-
branches: [ main ]
5+
branches: [ main, starkware-development ]
66

77
permissions:
88
# deployments permission to deploy GitHub pages website

Diff for: .github/workflows/cairo_1_programs.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: Cairo 1 programs execution
22

33
on:
44
push:
5-
branches: [ main ]
5+
branches: [ main, starkware-development ]
66
pull_request:
77
branches: [ '**' ]
88

Diff for: .github/workflows/hint_accountant.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: Update missing hints tracking issue
22

33
on:
44
push:
5-
branches: [ main ]
5+
branches: [ main, starkware-development ]
66

77
env:
88
CARGO_TERM_COLOR: always

Diff for: .github/workflows/hyper_threading_benchmarks.yml

+1-2
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ permissions:
88

99
on:
1010
pull_request:
11-
branches:
12-
- main
11+
branches: [ main, starkware-development ]
1312

1413
jobs:
1514
benchmark:

Diff for: .github/workflows/iai_main.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: iai Benchmark
22

33
on:
44
push:
5-
branches: [ main ]
5+
branches: [ main, starkware-development ]
66

77
jobs:
88
cache-iai-results:

Diff for: .github/workflows/rust.yml

+8-9
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name: QA
33
on:
44
merge_group:
55
push:
6-
branches: [ main ]
6+
branches: [ main, starkware-development ]
77
pull_request:
88
branches: [ '**' ]
99

@@ -42,13 +42,12 @@ jobs:
4242
strategy:
4343
matrix:
4444
# NOTE: we build cairo_bench_programs so clippy can check the benchmarks too
45-
program-target: [
46-
cairo_bench_programs,
47-
cairo_proof_programs,
48-
cairo_test_programs,
49-
cairo_1_test_contracts,
50-
cairo_2_test_contracts,
51-
]
45+
program-target:
46+
- cairo_bench_programs
47+
- cairo_proof_programs
48+
- cairo_test_programs
49+
- cairo_1_test_contracts
50+
- cairo_2_test_contracts
5251
name: Build Cairo programs
5352
runs-on: ubuntu-24.04
5453
steps:
@@ -162,7 +161,7 @@ jobs:
162161
key: all-programs-cache-${{ hashFiles('cairo_programs/**/*.cairo', 'examples/wasm-demo/src/array_sum.cairo') }}
163162

164163
lint:
165-
needs: build-programs
164+
needs: merge-caches
166165
name: Run Lints
167166
runs-on: ubuntu-24.04
168167
steps:

Diff for: .github/workflows/test_install.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name: Test dependencies and cairo-vm install
33
on:
44
merge_group:
55
push:
6-
branches: [ main ]
6+
branches: [ main, starkware-development ]
77
pull_request:
88
branches: [ '**' ]
99

Diff for: CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44

55
* feat: implement VirtualMachine::is_accessed [#2024](https://github.com/lambdaclass/cairo-vm/pull/2024)
66

7+
* fix: Keep None values in memory segments for the prover input info [#2021](https://github.com/lambdaclass/cairo-vm/pull/2021)
8+
79
* refactor: Clap attribute macros from #[clap(...)] to #[arg(...)] and #[command(...)] in v4.x [#2003] (https://github.com/lambdaclass/cairo-vm/pull/2003)
810

911
* fix: Fix `WriteReturnFp` error due to a bad loading of initial gas [#2015](https://github.com/lambdaclass/cairo-vm/pull/2015)

Diff for: vm/src/vm/runners/cairo_runner.rs

+11-5
Original file line numberDiff line numberDiff line change
@@ -1502,7 +1502,7 @@ impl CairoRunner {
15021502
.memory
15031503
.data
15041504
.iter()
1505-
.map(|segment| segment.iter().filter_map(|cell| cell.get_value()).collect())
1505+
.map(|segment| segment.iter().map(|cell| cell.get_value()).collect())
15061506
.collect();
15071507

15081508
let public_memory_offsets = self
@@ -1540,8 +1540,8 @@ impl CairoRunner {
15401540
pub struct ProverInputInfo {
15411541
/// A vector of trace entries, i.e. pc, ap, fp, where pc is relocatable.
15421542
pub relocatable_trace: Vec<TraceEntry>,
1543-
/// A vector of segments, where each segment is a vector of maybe relocatable values.
1544-
pub relocatable_memory: Vec<Vec<MaybeRelocatable>>,
1543+
/// A vector of segments, where each segment is a vector of maybe relocatable values or holes (`None`).
1544+
pub relocatable_memory: Vec<Vec<Option<MaybeRelocatable>>>,
15451545
/// A map from segment index to a vector of offsets within the segment, representing the public memory addresses.
15461546
pub public_memory_offsets: HashMap<usize, Vec<usize>>,
15471547
/// A map from the builtin segment index into its name.
@@ -5581,8 +5581,14 @@ mod tests {
55815581
offset: 0,
55825582
});
55835583
assert_eq!(prover_info.relocatable_trace, expected_trace);
5584-
assert_eq!(prover_info.relocatable_memory[0][3], expected_in_memory_0_3);
5585-
assert_eq!(prover_info.relocatable_memory[1][0], expected_in_memory_1_0);
5584+
assert_eq!(
5585+
prover_info.relocatable_memory[0][3],
5586+
Some(expected_in_memory_0_3)
5587+
);
5588+
assert_eq!(
5589+
prover_info.relocatable_memory[1][0],
5590+
Some(expected_in_memory_1_0)
5591+
);
55865592
assert!(prover_info.public_memory_offsets.is_empty());
55875593
assert_eq!(
55885594
prover_info.builtins_segments,

0 commit comments

Comments
 (0)