From f54f34c90785a8070bec0cf0bed1130b388f8036 Mon Sep 17 00:00:00 2001 From: Maxim Evtush <154841002+maximevtush@users.noreply.github.com> Date: Sat, 15 Feb 2025 22:35:46 +0100 Subject: [PATCH 1/5] Update hint_processor_utils.rs --- vm/src/hint_processor/hint_processor_utils.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vm/src/hint_processor/hint_processor_utils.rs b/vm/src/hint_processor/hint_processor_utils.rs index 3d442fbf7f..cfce23d5dc 100644 --- a/vm/src/hint_processor/hint_processor_utils.rs +++ b/vm/src/hint_processor/hint_processor_utils.rs @@ -272,7 +272,7 @@ mod tests { #[test] #[cfg_attr(target_arch = "wasm32", wasm_bindgen_test)] - fn compute_addr_from_reference_no_regiter_in_reference() { + fn compute_addr_from_reference_no_register_in_reference() { let mut vm = vm!(); vm.segments = segments![((1, 0), (4, 0))]; let mut hint_reference = HintReference::new(0, 0, false, false, true); From 149348a36d80ed0d0ee084feaf129af7cdda3d55 Mon Sep 17 00:00:00 2001 From: Maxim Evtush <154841002+maximevtush@users.noreply.github.com> Date: Sat, 15 Feb 2025 22:36:38 +0100 Subject: [PATCH 2/5] Update builtin_hint_processor_definition.rs --- .../builtin_hint_processor_definition.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/vm/src/hint_processor/builtin_hint_processor/builtin_hint_processor_definition.rs b/vm/src/hint_processor/builtin_hint_processor/builtin_hint_processor_definition.rs index f5ae7a96c4..7b74f902d2 100644 --- a/vm/src/hint_processor/builtin_hint_processor/builtin_hint_processor_definition.rs +++ b/vm/src/hint_processor/builtin_hint_processor/builtin_hint_processor_definition.rs @@ -11,7 +11,7 @@ use super::{ mod_circuit::{run_p_mod_circuit, run_p_mod_circuit_with_large_batch_size}, secp::{ ec_utils::{ - compute_doubling_slope_external_consts, compute_slope_and_assing_secp_p, + compute_doubling_slope_external_consts, compute_slope_and_assign_secp_p, ec_double_assign_new_y, ec_mul_inner, ec_negate_embedded_secp_p, ec_negate_import_secp_p, square_slope_minus_xs, }, @@ -553,7 +553,7 @@ impl HintProcessorLogic for BuiltinHintProcessor { &hint_data.ids_data, &hint_data.ap_tracking, ), - hint_code::COMPUTE_SLOPE_V1 => compute_slope_and_assing_secp_p( + hint_code::COMPUTE_SLOPE_V1 => compute_slope_and_assign_secp_p( vm, exec_scopes, &hint_data.ids_data, @@ -565,7 +565,7 @@ impl HintProcessorLogic for BuiltinHintProcessor { hint_code::SQUARE_SLOPE_X_MOD_P => { square_slope_minus_xs(vm, exec_scopes, &hint_data.ids_data, &hint_data.ap_tracking) } - hint_code::COMPUTE_SLOPE_V2 => compute_slope_and_assing_secp_p( + hint_code::COMPUTE_SLOPE_V2 => compute_slope_and_assign_secp_p( vm, exec_scopes, &hint_data.ids_data, @@ -593,7 +593,7 @@ impl HintProcessorLogic for BuiltinHintProcessor { "SECP256R1_P", ), hint_code::IMPORT_SECP256R1_P => import_secp256r1_p(exec_scopes), - hint_code::COMPUTE_SLOPE_WHITELIST => compute_slope_and_assing_secp_p( + hint_code::COMPUTE_SLOPE_WHITELIST => compute_slope_and_assign_secp_p( vm, exec_scopes, &hint_data.ids_data, From 2f430bde561fd550e4aad016869dac848bb86456 Mon Sep 17 00:00:00 2001 From: Maxim Evtush <154841002+maximevtush@users.noreply.github.com> Date: Sat, 15 Feb 2025 22:37:21 +0100 Subject: [PATCH 3/5] Update uint256_utils.rs --- .../hint_processor/builtin_hint_processor/uint256_utils.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/vm/src/hint_processor/builtin_hint_processor/uint256_utils.rs b/vm/src/hint_processor/builtin_hint_processor/uint256_utils.rs index 9c91fafa8a..b6a4c910ed 100644 --- a/vm/src/hint_processor/builtin_hint_processor/uint256_utils.rs +++ b/vm/src/hint_processor/builtin_hint_processor/uint256_utils.rs @@ -342,7 +342,7 @@ pub fn uint256_unsigned_div_rem( ids_data: &HashMap, ap_tracking: &ApTracking, ) -> Result<(), HintError> { - uint256_offseted_unsigned_div_rem(vm, ids_data, ap_tracking, 0, 1) + uint256_offsetted_unsigned_div_rem(vm, ids_data, ap_tracking, 0, 1) } /* @@ -363,10 +363,10 @@ pub fn uint256_expanded_unsigned_div_rem( ids_data: &HashMap, ap_tracking: &ApTracking, ) -> Result<(), HintError> { - uint256_offseted_unsigned_div_rem(vm, ids_data, ap_tracking, 1, 3) + uint256_offsetted_unsigned_div_rem(vm, ids_data, ap_tracking, 1, 3) } -pub fn uint256_offseted_unsigned_div_rem( +pub fn uint256_offsetted_unsigned_div_rem( vm: &mut VirtualMachine, ids_data: &HashMap, ap_tracking: &ApTracking, From 0c07bfdef89026322258555a58e00650fbe62695 Mon Sep 17 00:00:00 2001 From: Maxim Evtush <154841002+maximevtush@users.noreply.github.com> Date: Sat, 15 Feb 2025 22:38:02 +0100 Subject: [PATCH 4/5] Update dict_hint_utils.rs --- .../hint_processor/builtin_hint_processor/dict_hint_utils.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vm/src/hint_processor/builtin_hint_processor/dict_hint_utils.rs b/vm/src/hint_processor/builtin_hint_processor/dict_hint_utils.rs index 8e8ae9271b..eaec9f1679 100644 --- a/vm/src/hint_processor/builtin_hint_processor/dict_hint_utils.rs +++ b/vm/src/hint_processor/builtin_hint_processor/dict_hint_utils.rs @@ -954,7 +954,7 @@ mod tests { dict: HashMap::from([(MaybeRelocatable::from(5), MaybeRelocatable::from((1, 7)))]), default_value: MaybeRelocatable::from(2), }; - let expeced_dict_tracker = DictTracker { + let expected_dict_tracker = DictTracker { data: expected_dict, current_ptr: Relocatable::from((2, 3)), }; @@ -965,7 +965,7 @@ mod tests { .borrow() .trackers .get(&2), - Some(&expeced_dict_tracker) + Some(&expected_dict_tracker) ); } } From 9421415d16e5a19b78a0daaa7b0d964209a8b23d Mon Sep 17 00:00:00 2001 From: Maxim Evtush <154841002+maximevtush@users.noreply.github.com> Date: Sat, 15 Feb 2025 22:39:01 +0100 Subject: [PATCH 5/5] Update math_utils.rs --- vm/src/hint_processor/builtin_hint_processor/math_utils.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vm/src/hint_processor/builtin_hint_processor/math_utils.rs b/vm/src/hint_processor/builtin_hint_processor/math_utils.rs index eb65aed496..1c877b200c 100644 --- a/vm/src/hint_processor/builtin_hint_processor/math_utils.rs +++ b/vm/src/hint_processor/builtin_hint_processor/math_utils.rs @@ -1684,7 +1684,7 @@ mod tests { #[test] #[cfg_attr(target_arch = "wasm32", wasm_bindgen_test)] - fn unsigned_div_rem_inconsitent_memory() { + fn unsigned_div_rem_inconsistent_memory() { let hint_code = "from starkware.cairo.common.math_utils import assert_integer\nassert_integer(ids.div)\nassert 0 < ids.div <= PRIME // range_check_builtin.bound, \\\n f'div={hex(ids.div)} is out of the valid range.'\nids.q, ids.r = divmod(ids.value, ids.div)"; let mut vm = vm_with_range_check!(); //Initialize fp @@ -1816,7 +1816,7 @@ mod tests { #[test] #[cfg_attr(target_arch = "wasm32", wasm_bindgen_test)] - fn signed_div_rem_inconsitent_memory() { + fn signed_div_rem_inconsistent_memory() { let hint_code = "from starkware.cairo.common.math_utils import as_int, assert_integer\n\nassert_integer(ids.div)\nassert 0 < ids.div <= PRIME // range_check_builtin.bound, \\\n f'div={hex(ids.div)} is out of the valid range.'\n\nassert_integer(ids.bound)\nassert ids.bound <= range_check_builtin.bound // 2, \\\n f'bound={hex(ids.bound)} is out of the valid range.'\n\nint_value = as_int(ids.value, PRIME)\nq, ids.r = divmod(int_value, ids.div)\n\nassert -ids.bound <= q < ids.bound, \\\n f'{int_value} / {ids.div} = {q} is out of the range [{-ids.bound}, {ids.bound}).'\n\nids.biased_q = q + ids.bound"; let mut vm = vm_with_range_check!(); //Initialize fp