Fix from base type for FieldElement (#124)

* fix from &BaseType for FieldElement

* change suggested by clippy

---------

Co-authored-by: Sergio Chouhy <[email protected]>

Author: schouhy

crypto/src/merkle_tree/utils.rs

@@ -106,7 +106,7 @@ mod tests {
         let hashed_leaves = complete_until_power_of_two(&mut values);
 
         let mut expected_leaves = (1..6).map(FE::new).collect::<Vec<FE>>();
-        expected_leaves.extend(&[FE::new(5); 3]);
+        expected_leaves.extend([FE::new(5); 3]);
 
         for (leaf, expected_leaves) in hashed_leaves.iter().zip(expected_leaves) {
             assert_eq!(*leaf, expected_leaves);

math/src/field/element.rs

@@ -20,7 +20,7 @@ where
 {
     fn from(value: &F::BaseType) -> Self {
         Self {
-            value: value.clone(),
+            value: F::from_base_type(value.clone()),
         }
     }
 }

math/src/field/fields/u384_prime_field.rs

@@ -148,6 +148,13 @@ mod tests {
     type F23 = MontgomeryBackendPrimeField<MontgomeryConfig23>;
     type F23Element = FieldElement<F23>;
 
+    #[test]
+    fn from_base_type_works() {
+        let x = F23Element::from(&U384::from_u64(1));
+        let expected_value = U384::from_u64(12);
+        assert_eq!(x.value(), &expected_value);
+    }
+
     #[test]
     fn montgomery_backend_multiplication_works_0() {
         let x = F23Element::from(11_u64);